Skip to content

gvfs-helper: dramatically reduce progress noise #215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
derrickstolee merged 1 commit into from
Oct 24, 2019
Merged

gvfs-helper: dramatically reduce progress noise #215

derrickstolee merged 1 commit into from
Oct 24, 2019

Conversation

@derrickstolee
Copy link

@derrickstolee derrickstolee commented Oct 24, 2019

During development, it was very helpful to see the gvfs-helper do its
work to request a pack-file or download a loose object. When these
messages appear during normal use, it leads to a very noisy terminal
output.

Remove all progress indicators when downloading loose objects. We know
that these can be numbered in the thousands in certain kinds of history
calls, and would litter the terminal output with noise. This happens
during 'git fetch' or 'git pull' as well when the tip commits are
checked for the new refs.

Remove the "Requesting packfile with %ld objects" message, as this
operation is very fast. We quickly follow up with the more valuable
"Receiving packfile %ld%ld with %ld objects". When a large "git
checkout" causes many pack-file downloads, it is good to know that Git
is asking for data from the server.

cc: @mjcheetham

@derrickstolee
gvfs-helper: dramatically reduce progress noise
6e92f6a 
During development, it was very helpful to see the gvfs-helper do its
work to request a pack-file or download a loose object. When these
messages appear during normal use, it leads to a very noisy terminal
output.

Remove all progress indicators when downloading loose objects. We know
that these can be numbered in the thousands in certain kinds of history
calls, and would litter the terminal output with noise. This happens
during 'git fetch' or 'git pull' as well when the tip commits are
checked for the new refs.

Remove the "Requesting packfile with %ld objects" message, as this
operation is very fast. We quickly follow up with the more valuable
"Receiving packfile %ld%ld with %ld objects". When a large "git
checkout" causes many pack-file downloads, it is good to know that Git
is asking for data from the server.

Signed-off-by: Derrick Stolee <[email protected]>
@derrickstolee derrickstolee mentioned this pull request Oct 24, 2019
Closed
jeffhostetler
jeffhostetler approved these changes Oct 24, 2019
View reviewed changes
Copy link

@jeffhostetler jeffhostetler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks good. and yes, the loose object messages were too verbose (but good for debugging).

@derrickstolee derrickstolee merged commit 468727a into microsoft:features/sparse-checkout-2.23.0 Oct 24, 2019
@derrickstolee derrickstolee mentioned this pull request Oct 25, 2019
Merged
derrickstolee added a commit to microsoft/scalar that referenced this pull request Oct 25, 2019
@derrickstolee
Merge pull request #196: Update Git to show less progress in gvfs-helper
9be2785 
Resolves #195.

Includes the following updates to `microsoft/git`:

* microsoft/git#208: gvfs-helper: auto-retry after network errors, resource throttling, split GET and POST semantics.
* microsoft/git#215: gvfs-helper: dramatically reduce progress noise.
derrickstolee pushed a commit that referenced this pull request Jun 1, 2020
@jeffhostetler @derrickstolee
Merge first wave of gvfs-helper feature
b098b57 
Includes commits from these pull requests:

	#191
	#205
	#206
	#207
	#208
	#215
	#220
	#221

Signed-off-by: Derrick Stolee <[email protected]>
derrickstolee pushed a commit that referenced this pull request Jul 20, 2020
@jeffhostetler @derrickstolee
Merge first wave of gvfs-helper feature
93e7cf0 
Includes commits from these pull requests:

	#191
	#205
	#206
	#207
	#208
	#215
	#220
	#221

Signed-off-by: Derrick Stolee <[email protected]>
derrickstolee pushed a commit that referenced this pull request Jul 27, 2020
@jeffhostetler @derrickstolee
Merge first wave of gvfs-helper feature
08e7704 
Includes commits from these pull requests:

	#191
	#205
	#206
	#207
	#208
	#215
	#220
	#221

Signed-off-by: Derrick Stolee <[email protected]>
derrickstolee pushed a commit that referenced this pull request Jul 28, 2020
@jeffhostetler @derrickstolee
Merge first wave of gvfs-helper feature
d2e6d5d 
Includes commits from these pull requests:

	#191
	#205
	#206
	#207
	#208
	#215
	#220
	#221

Signed-off-by: Derrick Stolee <[email protected]>
derrickstolee pushed a commit that referenced this pull request Oct 6, 2020
@jeffhostetler @derrickstolee
Merge first wave of gvfs-helper feature
a608883 
Includes commits from these pull requests:

	#191
	#205
	#206
	#207
	#208
	#215
	#220
	#221

Signed-off-by: Derrick Stolee <[email protected]>
derrickstolee pushed a commit that referenced this pull request Oct 6, 2020
@jeffhostetler @derrickstolee
Merge first wave of gvfs-helper feature
64e523d 
Includes commits from these pull requests:

	#191
	#205
	#206
	#207
	#208
	#215
	#220
	#221

Signed-off-by: Derrick Stolee <[email protected]>
dscho pushed a commit that referenced this pull request Oct 6, 2020
@jeffhostetler @dscho
Merge first wave of gvfs-helper feature
93da4f0 
Includes commits from these pull requests:

	#191
	#205
	#206
	#207
	#208
	#215
	#220
	#221

Signed-off-by: Derrick Stolee <[email protected]>
derrickstolee pushed a commit that referenced this pull request Oct 9, 2020
@jeffhostetler @derrickstolee
Merge first wave of gvfs-helper feature
8c66c81 
Includes commits from these pull requests:

	#191
	#205
	#206
	#207
	#208
	#215
	#220
	#221

Signed-off-by: Derrick Stolee <[email protected]>
derrickstolee pushed a commit that referenced this pull request Oct 9, 2020
@jeffhostetler @derrickstolee
Merge first wave of gvfs-helper feature
0b30c5f 
Includes commits from these pull requests:

	#191
	#205
	#206
	#207
	#208
	#215
	#220
	#221

Signed-off-by: Derrick Stolee <[email protected]>
derrickstolee pushed a commit that referenced this pull request Oct 16, 2020
@jeffhostetler @derrickstolee
Merge first wave of gvfs-helper feature
5487ea4 
Includes commits from these pull requests:

	#191
	#205
	#206
	#207
	#208
	#215
	#220
	#221

Signed-off-by: Derrick Stolee <[email protected]>
derrickstolee pushed a commit that referenced this pull request Oct 19, 2020
@jeffhostetler @derrickstolee
Merge first wave of gvfs-helper feature
8d38f0f 
Includes commits from these pull requests:

	#191
	#205
	#206
	#207
	#208
	#215
	#220
	#221

Signed-off-by: Derrick Stolee <[email protected]>
mjcheetham pushed a commit that referenced this pull request Dec 15, 2020
@jeffhostetler @mjcheetham
Merge first wave of gvfs-helper feature
f507a72 
Includes commits from these pull requests:

	#191
	#205
	#206
	#207
	#208
	#215
	#220
	#221

Signed-off-by: Derrick Stolee <[email protected]>
mjcheetham pushed a commit that referenced this pull request Dec 15, 2020
@jeffhostetler @mjcheetham
Merge first wave of gvfs-helper feature
18d57de 
Includes commits from these pull requests:

	#191
	#205
	#206
	#207
	#208
	#215
	#220
	#221

Signed-off-by: Derrick Stolee <[email protected]>
dscho pushed a commit that referenced this pull request Dec 18, 2020
@jeffhostetler @dscho
Merge first wave of gvfs-helper feature
0efc144 
Includes commits from these pull requests:

	#191
	#205
	#206
	#207
	#208
	#215
	#220
	#221

Signed-off-by: Derrick Stolee <[email protected]>
dscho pushed a commit that referenced this pull request Dec 24, 2020
@jeffhostetler @dscho
Merge first wave of gvfs-helper feature
744a276 
Includes commits from these pull requests:

	#191
	#205
	#206
	#207
	#208
	#215
	#220
	#221

Signed-off-by: Derrick Stolee <[email protected]>
dscho pushed a commit that referenced this pull request Dec 28, 2020
@jeffhostetler @dscho
Merge first wave of gvfs-helper feature
dc48de4 
Includes commits from these pull requests:

	#191
	#205
	#206
	#207
	#208
	#215
	#220
	#221

Signed-off-by: Derrick Stolee <[email protected]>
dscho pushed a commit that referenced this pull request Mar 4, 2021
@jeffhostetler @dscho
Merge first wave of gvfs-helper feature
33b4b08 
Includes commits from these pull requests:

	#191
	#205
	#206
	#207
	#208
	#215
	#220
	#221

Signed-off-by: Derrick Stolee <[email protected]>
dscho pushed a commit that referenced this pull request Mar 4, 2021
@jeffhostetler @dscho
Merge first wave of gvfs-helper feature
1a03b17 
Includes commits from these pull requests:

	#191
	#205
	#206
	#207
	#208
	#215
	#220
	#221

Signed-off-by: Derrick Stolee <[email protected]>
dscho pushed a commit that referenced this pull request Mar 4, 2021
@jeffhostetler @dscho
Merge first wave of gvfs-helper feature
de4c45f 
Includes commits from these pull requests:

	#191
	#205
	#206
	#207
	#208
	#215
	#220
	#221

Signed-off-by: Derrick Stolee <[email protected]>
dscho pushed a commit that referenced this pull request Jan 1, 2025
@jeffhostetler @dscho
Merge first wave of gvfs-helper feature
980f6c4 
Includes commits from these pull requests:

	#191
	#205
	#206
	#207
	#208
	#215
	#220
	#221

Signed-off-by: Derrick Stolee <[email protected]>
dscho pushed a commit that referenced this pull request Feb 10, 2025
@jeffhostetler @dscho
Merge first wave of gvfs-helper feature
bcaafd5 
Includes commits from these pull requests:

	#191
	#205
	#206
	#207
	#208
	#215
	#220
	#221

Signed-off-by: Derrick Stolee <[email protected]>
dscho pushed a commit that referenced this pull request Feb 27, 2025
@jeffhostetler @dscho
Merge first wave of gvfs-helper feature
9320262 
Includes commits from these pull requests:

	#191
	#205
	#206
	#207
	#208
	#215
	#220
	#221

Signed-off-by: Derrick Stolee <[email protected]>
dscho pushed a commit that referenced this pull request Mar 5, 2025
@jeffhostetler @dscho
Merge first wave of gvfs-helper feature
0732c93 
Includes commits from these pull requests:

	#191
	#205
	#206
	#207
	#208
	#215
	#220
	#221

Signed-off-by: Derrick Stolee <[email protected]>
dscho pushed a commit that referenced this pull request Mar 5, 2025
@jeffhostetler @dscho
Merge first wave of gvfs-helper feature
5f50220 
Includes commits from these pull requests:

	#191
	#205
	#206
	#207
	#208
	#215
	#220
	#221

Signed-off-by: Derrick Stolee <[email protected]>
mjcheetham pushed a commit that referenced this pull request Mar 12, 2025
@jeffhostetler @mjcheetham
Merge first wave of gvfs-helper feature
daaf41f 
Includes commits from these pull requests:

	#191
	#205
	#206
	#207
	#208
	#215
	#220
	#221

Signed-off-by: Derrick Stolee <[email protected]>
mjcheetham pushed a commit that referenced this pull request Mar 17, 2025
@jeffhostetler @mjcheetham
Merge first wave of gvfs-helper feature
2116f15 
Includes commits from these pull requests:

	#191
	#205
	#206
	#207
	#208
	#215
	#220
	#221

Signed-off-by: Derrick Stolee <[email protected]>
dscho pushed a commit that referenced this pull request Jun 6, 2025
@jeffhostetler @dscho
Merge first wave of gvfs-helper feature
39871bb 
Includes commits from these pull requests:

	#191
	#205
	#206
	#207
	#208
	#215
	#220
	#221

Signed-off-by: Derrick Stolee <[email protected]>
dscho pushed a commit that referenced this pull request Jun 6, 2025
@jeffhostetler @dscho
Merge first wave of gvfs-helper feature
00a896d 
Includes commits from these pull requests:

	#191
	#205
	#206
	#207
	#208
	#215
	#220
	#221

Signed-off-by: Derrick Stolee <[email protected]>
dscho pushed a commit that referenced this pull request Jun 11, 2025
@jeffhostetler @dscho
Merge first wave of gvfs-helper feature
90f95f0 
Includes commits from these pull requests:

	#191
	#205
	#206
	#207
	#208
	#215
	#220
	#221

Signed-off-by: Derrick Stolee <[email protected]>
dscho pushed a commit that referenced this pull request Jun 13, 2025
@jeffhostetler @dscho
Merge first wave of gvfs-helper feature
8917b24 
Includes commits from these pull requests:

	#191
	#205
	#206
	#207
	#208
	#215
	#220
	#221

Signed-off-by: Derrick Stolee <[email protected]>
dscho pushed a commit that referenced this pull request Jun 16, 2025
@jeffhostetler @dscho
Merge first wave of gvfs-helper feature
f725920 
Includes commits from these pull requests:

	#191
	#205
	#206
	#207
	#208
	#215
	#220
	#221

Signed-off-by: Derrick Stolee <[email protected]>
dscho pushed a commit that referenced this pull request Jun 16, 2025
@jeffhostetler @dscho
Merge first wave of gvfs-helper feature
0387e3d 
Includes commits from these pull requests:

	#191
	#205
	#206
	#207
	#208
	#215
	#220
	#221

Signed-off-by: Derrick Stolee <[email protected]>
dscho pushed a commit that referenced this pull request Jun 16, 2025
@jeffhostetler @dscho
Merge first wave of gvfs-helper feature
a1cd891 
Includes commits from these pull requests:

	#191
	#205
	#206
	#207
	#208
	#215
	#220
	#221

Signed-off-by: Derrick Stolee <[email protected]>
dscho pushed a commit that referenced this pull request Jul 8, 2025
@jeffhostetler @dscho
Merge first wave of gvfs-helper feature
3bda4ed 
Includes commits from these pull requests:

	#191
	#205
	#206
	#207
	#208
	#215
	#220
	#221

Signed-off-by: Derrick Stolee <[email protected]>
dscho pushed a commit that referenced this pull request Aug 5, 2025
@jeffhostetler @dscho
Merge first wave of gvfs-helper feature
b4ab89b 
Includes commits from these pull requests:

	#191
	#205
	#206
	#207
	#208
	#215
	#220
	#221

Signed-off-by: Derrick Stolee <[email protected]>
dscho pushed a commit that referenced this pull request Aug 5, 2025
@jeffhostetler @dscho
Merge first wave of gvfs-helper feature
bb3b880 
Includes commits from these pull requests:

	#191
	#205
	#206
	#207
	#208
	#215
	#220
	#221

Signed-off-by: Derrick Stolee <[email protected]>
dscho pushed a commit that referenced this pull request Aug 8, 2025
@jeffhostetler @dscho
Merge first wave of gvfs-helper feature
fc35049 
Includes commits from these pull requests:

	#191
	#205
	#206
	#207
	#208
	#215
	#220
	#221

Signed-off-by: Derrick Stolee <[email protected]>
dscho pushed a commit that referenced this pull request Aug 8, 2025
@jeffhostetler @dscho
Merge first wave of gvfs-helper feature
b525093 
Includes commits from these pull requests:

	#191
	#205
	#206
	#207
	#208
	#215
	#220
	#221

Signed-off-by: Derrick Stolee <[email protected]>
dscho pushed a commit that referenced this pull request Aug 13, 2025
@jeffhostetler @dscho
Merge first wave of gvfs-helper feature
718bd3c 
Includes commits from these pull requests:

	#191
	#205
	#206
	#207
	#208
	#215
	#220
	#221

Signed-off-by: Derrick Stolee <[email protected]>
dscho pushed a commit that referenced this pull request Aug 19, 2025
@jeffhostetler @dscho
Merge first wave of gvfs-helper feature
659cd12 
Includes commits from these pull requests:

	#191
	#205
	#206
	#207
	#208
	#215
	#220
	#221

Signed-off-by: Derrick Stolee <[email protected]>
dscho pushed a commit that referenced this pull request Oct 17, 2025
@jeffhostetler @dscho
Merge first wave of gvfs-helper feature
6473463 
Includes commits from these pull requests:

	#191
	#205
	#206
	#207
	#208
	#215
	#220
	#221

Signed-off-by: Derrick Stolee <[email protected]>
dscho pushed a commit that referenced this pull request Oct 17, 2025
@jeffhostetler @dscho
Merge first wave of gvfs-helper feature
2608328 
Includes commits from these pull requests:

	#191
	#205
	#206
	#207
	#208
	#215
	#220
	#221

Signed-off-by: Derrick Stolee <[email protected]>
dscho pushed a commit that referenced this pull request Oct 17, 2025
@jeffhostetler @dscho
Merge first wave of gvfs-helper feature
d39d219 
Includes commits from these pull requests:

	#191
	#205
	#206
	#207
	#208
	#215
	#220
	#221

Signed-off-by: Derrick Stolee <[email protected]>
dscho pushed a commit that referenced this pull request Oct 28, 2025
@jeffhostetler @dscho
Merge first wave of gvfs-helper feature
8c6d05b 
Includes commits from these pull requests:

	#191
	#205
	#206
	#207
	#208
	#215
	#220
	#221

Signed-off-by: Derrick Stolee <[email protected]>
dscho pushed a commit that referenced this pull request Nov 5, 2025
@jeffhostetler @dscho
Merge first wave of gvfs-helper feature
850b2e6 
Includes commits from these pull requests:

	#191
	#205
	#206
	#207
	#208
	#215
	#220
	#221

Signed-off-by: Derrick Stolee <[email protected]>
dscho pushed a commit that referenced this pull request Nov 6, 2025
@jeffhostetler @dscho
Merge first wave of gvfs-helper feature
31e4c00 
Includes commits from these pull requests:

	#191
	#205
	#206
	#207
	#208
	#215
	#220
	#221

Signed-off-by: Derrick Stolee <[email protected]>
dscho pushed a commit that referenced this pull request Nov 6, 2025
@jeffhostetler @dscho
Merge first wave of gvfs-helper feature
9dbc3e2 
Includes commits from these pull requests:

	#191
	#205
	#206
	#207
	#208
	#215
	#220
	#221

Signed-off-by: Derrick Stolee <[email protected]>
dscho pushed a commit that referenced this pull request Nov 13, 2025
@jeffhostetler @dscho
Merge first wave of gvfs-helper feature
2d17b57 
Includes commits from these pull requests:

	#191
	#205
	#206
	#207
	#208
	#215
	#220
	#221

Signed-off-by: Derrick Stolee <[email protected]>
dscho pushed a commit that referenced this pull request Nov 17, 2025
@jeffhostetler @dscho
Merge first wave of gvfs-helper feature
4897c36 
Includes commits from these pull requests:

	#191
	#205
	#206
	#207
	#208
	#215
	#220
	#221

Signed-off-by: Derrick Stolee <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@jeffhostetler jeffhostetler jeffhostetler approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@derrickstolee @jeffhostetler