Skip to content

Conversation

@alxmrs
Copy link
Contributor

@alxmrs alxmrs commented Jun 10, 2025

I summarize the conclusions from the discussion in zarr-developers/zarr-python#2706 (comment), taking leaves from Tom and Ryan's books. I found that these docs didn't reflect the default state of Zarr and Xarray, and I hope this makes for less painful debugging for the next person.

I summarize the conclusions from the discussion in zarr-developers/zarr-python#2706 (comment), taking leave from Tom and Ryan's books. I found that these docs didn't reflect the default state of Zarr and Xarray, and I hope this makes for less painful debugging for the next person.
@welcome
Copy link

welcome bot commented Jun 10, 2025

Thank you for opening this pull request! It may take us a few days to respond here, so thank you for being patient.
If you have questions, some answers may be found in our contributing guidelines.


.. code:: python
import gcsfs
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like a great place to use inline tabs. I'm thinking 3 tabs: "URL", "bbstore", and "fsspec". Are you up for making that change? We already depend on this plugin: https://sphinx-inline-tabs.readthedocs.io/en/latest/usage.html

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great idea, and TIL the syntax. No problem at all.

@alxmrs
Copy link
Contributor Author

alxmrs commented Jun 11, 2025

Here's what it looks like in the readthedocs preview:
Screenshot 2025-06-11 at 11 18 22 AM
Screenshot 2025-06-11 at 11 19 01 AM
Screenshot 2025-06-11 at 11 19 06 AM

@alxmrs alxmrs requested a review from dcherian June 11, 2025 21:07
@max-sixty
Copy link
Collaborator

that looks great @alxmrs !

@dcherian dcherian merged commit c0461e7 into pydata:main Jun 11, 2025
30 of 32 checks passed
@welcome
Copy link

welcome bot commented Jun 11, 2025

Congratulations on completing your first pull request! Welcome to Xarray! We are proud of you, and hope to see you again! celebration gif

@alxmrs alxmrs deleted the alxmrs-updated-io-docs branch June 11, 2025 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants