Skip to content

Fix _get_default_engine_netcdf to check for h5netcdf #10557

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dcherian merged 5 commits into from
Jul 30, 2025
Merged

Fix _get_default_engine_netcdf to check for h5netcdf #10557

dcherian merged 5 commits into from
Jul 30, 2025

Conversation

@scottstanie
Copy link
Contributor

@scottstanie scottstanie commented Jul 21, 2025 •
edited by dcherian
Loading

The current implementation only checks for scipy and netCDF4. This adds the necessary check for h5netcdf.
Switches to using importlib.util.find_spec, as recommended by https://docs.python.org/3/library/importlib.html#importlib.util.find_spec

The unit test temporarily removes the other two backend options, then checks that h5netcdf is used.

@scottstanie
Fix _get_default_engine_netcdf to check for h5netcdf
786dd3b 
The current implementation only checks for `scipy` and `netCDF4`.
This adds the necessary check for `h5netcdf`.
Switches to using `importlib.util.find_spec`, as recommended by
https://docs.python.org/3/library/importlib.html#importlib.util.find_spec

The unit test temporarily removes the other two backend options,
then checks that `h5netcdf` is used.
Closes pydata#10401
@dcherian dcherian requested a review from kmuehlbauer July 21, 2025 16:40
dcherian
dcherian reviewed Jul 25, 2025
View reviewed changes
@dcherian
Copy link
Contributor

dcherian commented Jul 30, 2025

LGTM. Can you merge main and add a note to whats-new.rst please?

@dcherian dcherian added the plan to merge Final call for comments label Jul 30, 2025
@dcherian dcherian enabled auto-merge (squash) July 30, 2025 15:33
@dcherian dcherian merged commit c356a40 into pydata:main Jul 30, 2025
36 checks passed
@itcarroll itcarroll mentioned this pull request Sep 16, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dcherian dcherian dcherian approved these changes

@kmuehlbauer kmuehlbauer Awaiting requested review from kmuehlbauer

Assignees

No one assigned

Labels

io plan to merge Final call for comments topic-backends

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

api._get_default_engine_netcdf does not check for h5netcdf

2 participants

@scottstanie @dcherian