-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Coerce IndexVariable to Variable when assigning to data variables or coordinates
#10909
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+73
−29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IndexVariable to Variable when assigning to data variables or coordinates
IndexVariable to Variable when assigning to data variables or coordinatesIndexVariable to Variable when assigning to data variables or coordinates
dcherian
reviewed
Nov 11, 2025
af095e7 to
3370345
Compare
shoyer
approved these changes
Nov 11, 2025
Member
shoyer
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thank you!
dcherian
reviewed
Nov 11, 2025
jsignell
commented
Nov 12, 2025
jsignell
commented
Nov 12, 2025
jsignell
commented
Nov 12, 2025
jsignell
commented
Nov 12, 2025
Illviljan
reviewed
Nov 13, 2025
Co-authored-by: Illviljan <[email protected]>
dcherian
reviewed
Nov 14, 2025
dcherian
reviewed
Nov 14, 2025
benbovy
reviewed
Nov 17, 2025
Member
benbovy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @jsignell!
Just added two small comments.
benbovy
reviewed
Dec 2, 2025
Co-authored-by: Benoit Bovy <[email protected]>
12de1ad to
5fdaa13
Compare
dcherian
reviewed
Dec 2, 2025
dcherian
approved these changes
Dec 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
whats-new.rstNew functions/methods are listed inapi.rst