Skip to content

Conversation

@jsignell
Copy link
Contributor

@jsignell jsignell commented Nov 11, 2025

@jsignell jsignell changed the title Index variables Coerce it IndexVariable to Variable when assigning to data variables or coordinates Nov 11, 2025
@jsignell jsignell changed the title Coerce it IndexVariable to Variable when assigning to data variables or coordinates Coerce IndexVariable to Variable when assigning to data variables or coordinates Nov 11, 2025
Copy link
Member

@shoyer shoyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you!

@jsignell jsignell requested a review from dcherian November 12, 2025 22:07
Co-authored-by: Illviljan <[email protected]>
Copy link
Member

@benbovy benbovy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jsignell!

Just added two small comments.

@jsignell jsignell requested a review from benbovy December 1, 2025 14:15
Co-authored-by: Benoit Bovy <[email protected]>
@github-actions github-actions bot added topic-indexing topic-plotting topic-cftime topic-rolling Automation Github bots, testing workflows, release automation topic-DataTree Related to the implementation of a DataTree class labels Dec 2, 2025
@jsignell jsignell removed topic-plotting topic-cftime topic-rolling Automation Github bots, testing workflows, release automation topic-DataTree Related to the implementation of a DataTree class topic-indexing labels Dec 2, 2025
@jsignell jsignell requested review from benbovy and dcherian December 2, 2025 15:13
@dcherian dcherian merged commit 3425d96 into pydata:main Dec 2, 2025
37 checks passed
@jsignell jsignell deleted the index-variables branch December 2, 2025 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

5 participants