[PATCH] Updated fix for string to unicode fixes in time and datetime

[erocarrera]

BPO	1016
Nosy	@gvanrossum
Files	time_datetime_pystring_patch_2.diff

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2007-08-29.20:33:37.777>
created_at = <Date 2007-08-24.22:55:24.408>
labels = []
title = '[PATCH] Updated fix for string to unicode fixes in time and datetime'
updated_at = <Date 2007-09-02.20:04:44.980>
user = 'https://bugs.python.org/erocarrera'

bugs.python.org fields:

activity = <Date 2007-09-02.20:04:44.980>
actor = 'loewis'
assignee = 'none'
closed = True
closed_date = <Date 2007-08-29.20:33:37.777>
closer = 'gvanrossum'
components = []
creation = <Date 2007-08-24.22:55:24.408>
creator = 'ero.carrera'
dependencies = []
files = ['8309']
hgrepos = []
issue_num = 1016
keywords = ['patch']
message_count = 2.0
messages = ['55279', '55433']
nosy_count = 2.0
nosy_names = ['gvanrossum', 'ero.carrera']
pr_nums = []
priority = 'normal'
resolution = 'duplicate'
stage = None
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue1016'
versions = ['Python 3.0']

[erocarrera]

Small patch for the references leak in datetime and changed a strlen to
PyUnicode_GET_SIZE() in time

[gvanrossum]

The issue in datetimemodule.c was already fixed.

The fix to timemodule.c is wrong -- when there are non-ASCII characters
in the unicode string, the length of the UTF-8 conversion is not equal
to that of the original Unicode string.