fnmatch regular expression can be improved

[AlbertoGalera]

BPO	25734
Nosy	@bitdancer

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2015-11-25.15:06:27.644>
created_at = <Date 2015-11-25.14:43:46.713>
labels = ['type-bug', 'library']
title = 'fnmatch regular expression can be improved'
updated_at = <Date 2015-11-25.15:06:27.616>
user = 'https://bugs.python.org/AlbertoGalera'

bugs.python.org fields:

activity = <Date 2015-11-25.15:06:27.616>
actor = 'r.david.murray'
assignee = 'none'
closed = True
closed_date = <Date 2015-11-25.15:06:27.644>
closer = 'r.david.murray'
components = ['Library (Lib)']
creation = <Date 2015-11-25.14:43:46.713>
creator = 'Alberto Galera'
dependencies = []
files = []
hgrepos = []
issue_num = 25734
keywords = []
message_count = 2.0
messages = ['255361', '255362']
nosy_count = 2.0
nosy_names = ['r.david.murray', 'Alberto Galera']
pr_nums = []
priority = 'normal'
resolution = 'rejected'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue25734'
versions = ['Python 2.7']

[AlbertoGalera]

# https://hg.python.org/cpython/file/tip/Lib/fnmatch.py
fnmatch reviewing the code I've noticed that the outcome of the regular expression all returns generated in the first result

l97:
res = res + '.*'
to:
res = res + '.*?'

l100:
return res + '\Z(?ms)'
to:
return res + '$(?ms)'

example test:

import re
import fnmatch

urls = ['example/l1/l2/test3-1.py',
        'example/l1/test2-1.py',
        'example/l1/test2-2.py',
        'example/l1/l2/l3/test4-1.py']

regex = fnmatch.translate('example/*')
# 'example\\/.*\\Z(?ms)'
re.findall(regex, "\n".join(urls))
# return ['example/l1/l2/test3-1.py\nexample/l1/test2-1.py\nexample/l1/test2-2.py\nexample/l1/l2/l3/test4-1.py']

# suggested change
re.findall('example\\/.*?$(?ms)', "\n".join(urls))
# return ['example/l1/l2/test3-1.py',
# 'example/l1/test2-1.py',
# 'example/l1/test2-2.py',
# 'example/l1/l2/l3/test4-1.py']

[bitdancer]

That would be a backward incompatible behavior change. The patterns are designed to be used on single filenames, not on newline separated filenames.