gh-100833: Remove 'volatile' qualifiers in fsum algorithm #100845
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdickinson
changed the title
mdickinson
changed the title
mdickinson
added
skip news
DO-NOT-MERGE
🔨 test-with-buildbots
|
🤖 New build scheduled with the buildbot fleet by @mdickinson for commit 6b6631f 🤖 If you want to schedule another build, you need to add the |
bedevere-bot
removed
the
🔨 test-with-buildbots
This comment was marked as outdated.
This comment was marked as outdated.
mdickinson
added
the
🔨 test-with-buildbots
|
🤖 New build scheduled with the buildbot fleet by @mdickinson for commit 9e5da47 🤖 If you want to schedule another build, you need to add the |
bedevere-bot
removed
the
🔨 test-with-buildbots
mdickinson
changed the title
mdickinson
added
type-feature
rhettinger
approved these changes
Jan 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the
volatilequalifier on various intermediate quantities in themath.fsumimplementation, and updates the notes preceding the algorithm accordingly (as well as fixing some of the exsting notes). See the linked issue for discussion.