gh-100985: Consistently wrap IPv6 IP address during CONNECT #100986
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All commit authors signed the Contributor License Agreement. |
derekhiggins
force-pushed
the
fix-square
branch
2 times, most recently
from
383fbf1 to
6c35f40
Compare
derekhiggins
force-pushed
the
fix-square
branch
from
e886d29 to
a613ee4
Compare
derekhiggins
force-pushed
the
fix-square
branch
from
a613ee4 to
c3d6794
Compare
Update _get_hostport to always remove square brackets from IPv6 addresses. Then add them if needed in "CONNECT .." and "Host: ".
derekhiggins
force-pushed
the
fix-square
branch
from
c3d6794 to
43f9b0b
Compare
arhadthedev
added
the
stdlib
serhiy-storchaka
approved these changes
Feb 17, 2024
Member
serhiy-storchaka
left a comment
serhiy-storchaka
left a comment
There was a problem hiding this comment.
LGTM, with some nitpicks.
Misc/NEWS.d/next/Library/2023-01-12-14-16-01.gh-issue-100985.GT5Fvd.rst
Outdated
Show resolved
Hide resolved
serhiy-storchaka
added
needs backport to 3.11
|
Thanks @derekhiggins for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Feb 17, 2024
…thonGH-100986) Update _get_hostport to always remove square brackets from IPv6 addresses. Then add them if needed in "CONNECT .." and "Host: ". (cherry picked from commit 465db27) Co-authored-by: Derek Higgins <[email protected]>
|
Sorry, @derekhiggins and @serhiy-storchaka, I could not cleanly backport this to |
|
GH-115591 is a backport of this pull request to the 3.12 branch. |
serhiy-storchaka
pushed a commit
that referenced
this pull request
Feb 17, 2024
…H-100986) (GH-115591) Update _get_hostport to always remove square brackets from IPv6 addresses. Then add them if needed in "CONNECT .." and "Host: ". (cherry picked from commit 465db27) Co-authored-by: Derek Higgins <[email protected]>
serhiy-storchaka
pushed a commit
to serhiy-storchaka/cpython
that referenced
this pull request
Feb 17, 2024
…ECT (pythonGH-100986) Update _get_hostport to always remove square brackets from IPv6 addresses. Then add them if needed in "CONNECT .." and "Host: ". (cherry picked from commit 465db27) Co-authored-by: Derek Higgins <[email protected]>
|
GH-115606 is a backport of this pull request to the 3.11 branch. |
serhiy-storchaka
added a commit
that referenced
this pull request
Feb 17, 2024
…H-100986) (GH-115606) Update _get_hostport to always remove square brackets from IPv6 addresses. Then add them if needed in "CONNECT .." and "Host: ". (cherry picked from commit 465db27) Co-authored-by: Derek Higgins <[email protected]>
woodruffw
pushed a commit
to woodruffw-forks/cpython
that referenced
this pull request
Mar 4, 2024
…thonGH-100986) Update _get_hostport to always remove square brackets from IPv6 addresses. Then add them if needed in "CONNECT .." and "Host: ".
diegorusso
pushed a commit
to diegorusso/cpython
that referenced
this pull request
Apr 17, 2024
…thonGH-100986) Update _get_hostport to always remove square brackets from IPv6 addresses. Then add them if needed in "CONNECT .." and "Host: ".
LukasWoodtli
pushed a commit
to LukasWoodtli/cpython
that referenced
this pull request
Jan 22, 2025
…thonGH-100986) Update _get_hostport to always remove square brackets from IPv6 addresses. Then add them if needed in "CONNECT .." and "Host: ".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update _get_hostport to always remove square brackets from IPv6 addresses. Then add them if needed
in "CONNECT .." and "Host: ".