gh-101015: Fix typing.get_type_hints with unpacked *tuple (PEP 646)
#101031
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sobolevn
requested review from
AlexWaygood,
Fidget-Spinner,
JelleZijlstra and
gvanrossum
as code owners
sobolevn
force-pushed
the
issue-101015
branch
from
8e11117 to
b28ee58
Compare
sobolevn
force-pushed
the
issue-101015
branch
from
b28ee58 to
3bb3975
Compare
JelleZijlstra
approved these changes
Jan 18, 2023
AlexWaygood
reviewed
Jan 22, 2023
Member
AlexWaygood
left a comment
AlexWaygood
left a comment
There was a problem hiding this comment.
This looks great @sobolevn -- thank you! I don't think it's any more hacky than the current code ;)
Just a small nit with the NEWS entry:
Misc/NEWS.d/next/Library/2023-01-14-12-58-21.gh-issue-101015.stWFid.rst
Outdated
Show resolved
Hide resolved
AlexWaygood
approved these changes
Jan 23, 2023
Member
AlexWaygood
left a comment
AlexWaygood
left a comment
There was a problem hiding this comment.
The Windows test failure is unrelated
AlexWaygood
changed the title
typing.ForwardRef with *tuple unpacktyping.get_type_hints with unpacked *tuple (PEP 646)
Contributor
|
Thanks @sobolevn for the PR, and @AlexWaygood for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11. |
|
GH-101254 is a backport of this pull request to the 3.11 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jan 23, 2023
…PEP 646) (pythonGH-101031) (cherry picked from commit 807d6b5) Co-authored-by: Nikita Sobolev <[email protected]>
miss-islington
added a commit
that referenced
this pull request
Jan 23, 2023
…6) (GH-101031) (cherry picked from commit 807d6b5) Co-authored-by: Nikita Sobolev <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Couple of thoughts:
ForwardRefhas way too many flagstyping.pyfix 😆), better ideas are welcome*tuple[int, int]is improperly evaluated byget_type_hints#101015