-
-
Notifications
You must be signed in to change notification settings - Fork 33.7k
gh-101821: Cover ast.main function
#101822
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Oh, |
97969cf to
a5821a9
Compare
|
@hauntsaninja can you please take a look? :) |
hauntsaninja
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Weird that the default indentation is 3
|
Thanks @sobolevn for the PR, and @hauntsaninja for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11. |
|
Sorry, @sobolevn and @hauntsaninja, I could not cleanly backport this to |
|
Sorry @sobolevn and @hauntsaninja, I had trouble checking out the |
|
Thanks! Fine not to backport since there are already merge conflicts |
Couple of comments on the implementation:
script_helper.run_python_until_endhas@support.requires_subprocess()guard, so it is should be safe for envs wheresubprocessis not availableos_helper.temp_diris also widely used for temp files, it even catchesOSErrorand warns about itSo, this new cases should not add any test falkiness or new failures 🙂
ast.mainis not covered #101821