gh-102947: Improve traceback when calling fields() on a non-dataclass
#102948
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexWaygood
added
the
stdlib
Member
Author
|
I'm unsure whether this counts as a feature or a backportable bugfix. I'm easy either way. |
Member
I'd vote for bug fix. |
AlexWaygood
added
needs backport to 3.10
Contributor
|
Thanks @AlexWaygood for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11. |
Contributor
|
Sorry, @AlexWaygood, I could not cleanly backport this to |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Mar 23, 2023
…ataclass (pythonGH-102948) (cherry picked from commit baf4eb0) Co-authored-by: Alex Waygood <[email protected]>
|
GH-102951 is a backport of this pull request to the 3.11 branch. |
|
GH-102954 is a backport of this pull request to the 3.10 branch. |
AlexWaygood
added a commit
to AlexWaygood/cpython
that referenced
this pull request
Mar 23, 2023
…a non-dataclass (python#102948)
miss-islington
added a commit
that referenced
this pull request
Mar 23, 2023
…ss (GH-102948) (cherry picked from commit baf4eb0) Co-authored-by: Alex Waygood <[email protected]>
AlexWaygood
added a commit
that referenced
this pull request
Mar 23, 2023
Fidget-Spinner
pushed a commit
to Fidget-Spinner/cpython
that referenced
this pull request
Mar 27, 2023
warsaw
pushed a commit
to warsaw/cpython
that referenced
this pull request
Apr 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dataclasses.fieldsis called on a non-dataclass #102947