Skip to content

GH-103085: Fix python locale.getencoding not to emit deprecation warning #103086

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
corona10 merged 2 commits into from
Mar 30, 2023
Merged

GH-103085: Fix python locale.getencoding not to emit deprecation warning #103086

corona10 merged 2 commits into from
Mar 30, 2023

Conversation

@youknowone
Copy link
Contributor

@youknowone youknowone commented Mar 28, 2023 •
edited by bedevere-bot
Loading

@bedevere-bot bedevere-bot mentioned this pull request Mar 28, 2023
Closed
@youknowone youknowone marked this pull request as ready for review March 28, 2023 15:05
@corona10 corona10 self-requested a review March 28, 2023 15:24
@corona10 corona10 self-assigned this Mar 28, 2023
corona10
corona10 requested changes Mar 30, 2023
View reviewed changes
Copy link
Member

@corona10 corona10 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for catching this.
Here is a nit comment.

@bedevere-bot
Copy link

bedevere-bot commented Mar 30, 2023

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@youknowone youknowone force-pushed the locale-getencoding-not-deprecated branch from 7e74c5d to 3f41d29 Compare March 30, 2023 15:41
@youknowone
Copy link
Contributor Author

youknowone commented Mar 30, 2023

I have made the requested changes; please review again

Thank you for the review 😄

@bedevere-bot
Copy link

bedevere-bot commented Mar 30, 2023

Thanks for making the requested changes!

@corona10: please review the changes made to this pull request.

@bedevere-bot bedevere-bot requested a review from corona10 March 30, 2023 15:41
@corona10 corona10 changed the title GH-103085 Fix python locale.getencoding not to warns deprecated GH-103085: Fix python locale.getencoding not to emit deprecation warning recursively. Mar 30, 2023
@corona10 corona10 changed the title GH-103085: Fix python locale.getencoding not to emit deprecation warning recursively. GH-103085: Fix python locale.getencoding not to emit deprecation warning Mar 30, 2023
corona10
corona10 approved these changes Mar 30, 2023
View reviewed changes
Copy link
Member

@corona10 corona10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@corona10 corona10 merged commit 21e9de3 into python:main Mar 30, 2023
warsaw pushed a commit to warsaw/cpython that referenced this pull request Apr 11, 2023
@youknowone @warsaw
pythongh-103085: Fix python locale.getencoding not to emit deprecatio…
65efc81 
…n warning (pythongh-103086)
@youknowone youknowone deleted the locale-getencoding-not-deprecated branch June 21, 2023 06:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@corona10 corona10 corona10 approved these changes

Assignees

@corona10 corona10

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@youknowone @bedevere-bot @corona10