Skip to content

gh-104499: IDLE - fix completions for tk aqua 8.7 #104591

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
terryjreedy merged 1 commit into from
May 18, 2023
Merged

gh-104499: IDLE - fix completions for tk aqua 8.7 #104591

terryjreedy merged 1 commit into from
May 18, 2023

Conversation

@terryjreedy
Copy link
Member

@terryjreedy terryjreedy commented May 17, 2023 •
edited by bedevere-bot
Loading

@terryjreedy terryjreedy added the needs backport to 3.11 only security fixes label May 17, 2023
@terryjreedy terryjreedy self-assigned this May 17, 2023
@bedevere-bot bedevere-bot mentioned this pull request May 17, 2023
Closed
chrstphrchvz
chrstphrchvz reviewed May 17, 2023
View reviewed changes
@chrstphrchvz
Copy link
Contributor

chrstphrchvz commented May 17, 2023

I have verified that this change avoids the issue for current Tk Aqua 8.7 on macOS 12.6.5 Monterey (Intel).

Before:
Screen Shot 2023-05-17 at 5 54 57 PM
After:
Screen Shot 2023-05-17 at 5 52 15 PM

@terryjreedy terryjreedy merged commit 678bf57 into python:main May 18, 2023
@miss-islington
Copy link
Contributor

miss-islington commented May 18, 2023

Thanks @terryjreedy for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

@bedevere-bot
Copy link

bedevere-bot commented May 18, 2023

GH-104596 is a backport of this pull request to the 3.11 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label May 18, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 18, 2023
@terryjreedy @miss-islington
pythongh-104499: IDLE - fix completions for tk aqua 8.7 (pythonGH-104591
ff8ef9d 
)

(cherry picked from commit 678bf57)

Co-authored-by: Terry Jan Reedy <[email protected]>
@terryjreedy terryjreedy deleted the compdraw branch May 18, 2023 01:37
JelleZijlstra pushed a commit to JelleZijlstra/cpython that referenced this pull request May 18, 2023
@terryjreedy @JelleZijlstra
pythongh-104499: IDLE - fix completions for tk aqua 8.7 (python#104591)
a5a7344
terryjreedy added a commit that referenced this pull request May 18, 2023
@miss-islington @terryjreedy
[3.11] gh-104499: IDLE - fix completions for tk aqua 8.7 (GH-104591) (#…
e96fb39 
…104596)

gh-104499: IDLE - fix completions for tk aqua 8.7 (GH-104591)
(cherry picked from commit 678bf57)

Co-authored-by: Terry Jan Reedy <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@chrstphrchvz chrstphrchvz chrstphrchvz left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@terryjreedy terryjreedy

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@terryjreedy @chrstphrchvz @miss-islington @bedevere-bot