gh-106210 Remove Emscripten import trampoline #106211
Conversation
As far as I know this isn't actually needed. It was originally added to work around typos in the CPython test suite, but those typos have since been fixed and I am unaware of any user code that requires the trampoline.
hoodmane
requested review from
brettcannon,
ericsnowcurrently,
ncoghlan and
warsaw
as code owners
|
/buildbot Emscripten |
brettcannon
added
the
🔨 test-with-buildbots
|
🤖 New build scheduled with the buildbot fleet by @brettcannon for commit e55628c 🤖 If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again. |
bedevere-bot
removed
the
🔨 test-with-buildbots
|
@hoodmane Would you mind adding a news file? |
|
How's that? |
Misc/NEWS.d/next/Core and Builtins/2023-06-28-13-19-20.gh-issue-106210.oE7VMn.rst
Outdated
Show resolved
Hide resolved
…e-106210.oE7VMn.rst
|
!buildbot .emscripten. |
|
🤖 New build scheduled with the buildbot fleet by @brettcannon for commit b75fe1f 🤖 The command will test the builders whose names match following regular expression: The builders matched are:
|
Thanks! I made it a complete sentence and added a bit more detail as to why the removal was happening. |
|
!buildbot .*emscripten |
|
🤖 New build scheduled with the buildbot fleet by @brettcannon for commit fc3a1b4 🤖 The command will test the builders whose names match following regular expression: The builders matched are:
|
|
Thanks! |
3 participants
As far as I know this isn't actually needed. It was originally added to work around typos in the CPython test suite, but those typos have since been fixed and I am unaware of any user code that requires the trampoline.
#106210