gh-108111: Flush gzip write buffer before seeking, fixing bad writes #108341
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All commit authors signed the Contributor License Agreement. |
2 tasks
encukou
approved these changes
Aug 23, 2023
Contributor
|
GH-108402 is a backport of this pull request to the 3.12 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Aug 24, 2023
…rites (pythonGH-108341) (cherry picked from commit 2eb60c1) Co-authored-by: Chris Markiewicz <[email protected]> Co-authored-by: Łukasz Langa <[email protected]>
Yhg1s
pushed a commit
that referenced
this pull request
Aug 24, 2023
…writes (GH-108341) (#108402) gh-108111: Flush gzip write buffer before seeking, fixing bad writes (GH-108341) (cherry picked from commit 2eb60c1) Co-authored-by: Chris Markiewicz <[email protected]> Co-authored-by: Łukasz Langa <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue described in detail in #108111.
Short story:
write(x); seek(len(x)); write(x)results inb''.join([x, bytes(len(x)), x])being written. This is due to buffered writes not updating theGzipFile.offset()until flushed. It's possible there could be something more efficient, but this seemed like the simplest solution.