[3.12] gh-109118: Fix runtime crash when NameError happens in PEP 695 function (GH-109123) #109173
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…function (python#109123) (cherry picked from commit 17f9941)
…EP 695 function (pythonGH-109123). (cherry picked from commit 17f9941) Co-authored-by: Jelle Zijlstra <[email protected]>
This was referenced Sep 9, 2023
JelleZijlstra
added
the
🔨 test-with-refleak-buildbots
|
🤖 New build scheduled with the buildbot fleet by @JelleZijlstra for commit e28d114 🤖 If you want to schedule another build, you need to add the 🔨 test-with-refleak-buildbots label again. |
bedevere-bot
removed
the
🔨 test-with-refleak-buildbots
Member
Author
|
I had to redo this from scratch because the code is so different on main, so running it through the buildbots again to make sure I got it right. |
Member
Author
|
@Yhg1s this one is important to get into 3.12. The refleak buildbots are failing, but it's a refleak on |
carljm
approved these changes
Sep 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(cherry picked from commit 17f9941)