Skip to content

GH-110455: Guard assert(tstate->thread_id > 0) with #ifndef HAVE_PTHREAD_STUBS #110487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
brettcannon merged 2 commits into from
Oct 6, 2023
Merged

GH-110455: Guard assert(tstate->thread_id > 0) with #ifndef HAVE_PTHREAD_STUBS #110487

brettcannon merged 2 commits into from
Oct 6, 2023

Conversation

@brettcannon
Copy link
Member

@brettcannon brettcannon commented Oct 6, 2023 •
edited by bedevere-app bot
Loading

@brettcannon brettcannon self-assigned this Oct 6, 2023
@bedevere-app bedevere-app bot mentioned this pull request Oct 6, 2023
Closed
@brettcannon brettcannon added the needs backport to 3.12 only security fixes label Oct 6, 2023
ericsnowcurrently
ericsnowcurrently approved these changes Oct 6, 2023
View reviewed changes
Copy link
Member

@ericsnowcurrently ericsnowcurrently left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brettcannon brettcannon merged commit 5fd8821 into python:main Oct 6, 2023
@brettcannon brettcannon deleted the issue110455-thread_id-is-zero branch October 6, 2023 23:12
@miss-islington
Copy link
Contributor

miss-islington commented Oct 6, 2023

Thanks @brettcannon for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 6, 2023
@brettcannon @miss-islington
pythonGH-110455: Guard assert(tstate->thread_id > 0) with `GH-ifnde…
2a19c5b 
…f HAVE_PTHREAD_STUBS` (pythonGH-110487)

(cherry picked from commit 5fd8821)

Co-authored-by: Brett Cannon <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented Oct 6, 2023

GH-110491 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 only security fixes label Oct 6, 2023
brettcannon added a commit that referenced this pull request Oct 6, 2023
@miss-islington @brettcannon
[3.12] GH-110455: Guard assert(tstate->thread_id > 0) with `GH-ifnd…
2465fe0 
…ef HAVE_PTHREAD_STUBS` (GH-110487) (GH-110491)

GH-110455: Guard `assert(tstate->thread_id > 0)` with `GH-ifndef HAVE_PTHREAD_STUBS` (GH-110487)
(cherry picked from commit 5fd8821)

Co-authored-by: Brett Cannon <[email protected]>
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
@brettcannon @Glyphack
pythonGH-110455: Guard assert(tstate->thread_id > 0) with `#ifndef …
5bfee3d 
…HAVE_PTHREAD_STUBS` (pythonGH-110487)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ericsnowcurrently ericsnowcurrently ericsnowcurrently approved these changes

Assignees

@brettcannon brettcannon

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@brettcannon @miss-islington @ericsnowcurrently