GH-104584: Fix refleak when tracing through calls #110593
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandtbucher
added
type-bug
brandtbucher
changed the title
gvanrossum
approved these changes
Oct 10, 2023
Member
gvanrossum
left a comment
gvanrossum
left a comment
There was a problem hiding this comment.
(I love how this already violates a likely future C API requirement. Glad that those requirements don't apply to internal APIs. :-)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This modifies
_PyFunction_LookupByVersionto return a borrowed reference, which is what the caller assumes (and most internal "lookup" functions do, in general).