gh-112062: Make _struct module thread-safe in --disable-gil builds
#112094
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* use `PyDict_GetItemRef` instead of `PyDict_GetItemWithError` in `cache_struct_converter` to avoid usage of borrowed ref with explicit incref * clear cache dict but preserve the reference in `_clearcache_impl` * create cache dict in `_structmodule_exec`
Contributor
|
Thanks @chgnrdv. This is going to conflict with @serhiy-storchaka's #112076, which also makes Maybe remove that part and just keep the changes to |
colesbury
approved these changes
Nov 15, 2023
Contributor
colesbury
left a comment
colesbury
left a comment
There was a problem hiding this comment.
Thanks, this lgtm. @kumaraditya303, would you please review this change?
aisk
pushed a commit
to aisk/cpython
that referenced
this pull request
Feb 11, 2024
… builds (python#112094) * pythongh-112062: Make `_struct` module thread-safe in --disable-gil builds
Glyphack
pushed a commit
to Glyphack/cpython
that referenced
this pull request
Sep 2, 2024
… builds (python#112094) * pythongh-112062: Make `_struct` module thread-safe in --disable-gil builds
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #112062
_clearcache_impl_structmodule_exec_structmodule thread-safe in--disable-gilbuilds #112062