Skip to content

[3.12] gh-112503: Fix test_sys on WASI #112505

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ericsnowcurrently merged 1 commit into from
Nov 29, 2023
Merged

[3.12] gh-112503: Fix test_sys on WASI #112505

ericsnowcurrently merged 1 commit into from
Nov 29, 2023

Conversation

@ericsnowcurrently
Copy link
Member

@ericsnowcurrently ericsnowcurrently commented Nov 29, 2023 •
edited by bedevere-app bot
Loading

gh-110713 added some tests that use the interpreters module but did not accommodated builds that don't support subinterpreters (incl. an interpreters module). We fix that here by catching ImportError and skipping tests as appropriate.

@bedevere-app bedevere-app bot mentioned this pull request Nov 29, 2023
Closed
@bedevere-app bedevere-app bot added awaiting core review tests Tests in the Lib/test dir labels Nov 29, 2023
@ericsnowcurrently ericsnowcurrently enabled auto-merge (squash) November 29, 2023 00:12
@ericsnowcurrently ericsnowcurrently merged commit 3e6b328 into python:3.12 Nov 29, 2023
@brettcannon
Copy link
Member

brettcannon commented Nov 29, 2023

Thanks!

@ericsnowcurrently ericsnowcurrently deleted the fix-wasi branch November 29, 2023 01:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brettcannon brettcannon Awaiting requested review from brettcannon

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ericsnowcurrently @brettcannon