Skip to content

Conversation

@alphavector
Copy link
Contributor

@alphavector alphavector commented Dec 17, 2023

This PR seems to be a bit stuck, this is an attempt to resuscitate it

@bedevere-app
Copy link

bedevere-app bot commented Dec 17, 2023

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@alphavector alphavector changed the title gh-87264: convert tarinfo type to stat type gh-87264: Convert tarinfo type to stat type Dec 17, 2023
Copy link
Contributor

@willingc willingc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Flagging this for core dev discussion. Attribution should be shared with #29974

@bedevere-app
Copy link

bedevere-app bot commented Dec 19, 2023

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

And if you don't make the requested changes, you will be put in the comfy chair!

@willingc
Copy link
Contributor

Hi @alphavector. I flagged this for core dev discussion since a similar PR was opened earlier on this subject: #29974

I would like to make sure that the first PR gets attribution/thanks for the change as well as you.

@ethanfurman
Copy link
Member

This PR appears to be a copy/paste of the other, with only a slight modification of the test. Since the changes are fairly simple, and @val-shkolnikov claims they signed the CLA with a different email, and @alphavector was kind enough to push for this, I'm happy to accept it and merge (with attribution for both).

@willingc
Copy link
Contributor

@ethanfurman Thanks for doing so. I will go ahead and approve and let you handle the merge/attribution. 😄

@Mariatta
Copy link
Member

Attribution can be added by including "Co-Authored-by: " at the end of commit message when merging the PR.
https://docs.github.com/en/pull-requests/committing-changes-to-your-project/creating-and-editing-commits/creating-a-commit-with-multiple-authors#required-co-author-information

@alphavector
Copy link
Contributor Author

Yes, I had no goal to downplay @val-shkolnikov's contribution, my involvement is minimal, the PR was all set and I gave it a little push

@willingc
Copy link
Contributor

Thanks @alphavector. I appreciate the effort. I hope to see more contributions from you in the future. ☀️

ryan-duve pushed a commit to ryan-duve/cpython that referenced this pull request Dec 26, 2023
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants