gh-114328: tty cbreak mode should not alter ICRNL #114335
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CR -> NL mapping should be inherited in cbreak mode as OSes do not specify altering it as part of their `stty` cbreak mode definition.
gpshead
added
type-bug
Contributor
|
@gpshead, please see #114328 (comment) |
Member
Author
|
Updated further after conversation on the issue, see the discussion there. This should be ready. |
Member
serhiy-storchaka
left a comment
serhiy-storchaka
left a comment
There was a problem hiding this comment.
If it is considered a bugfix, why versionchanged is needed?
Member
Author
It's unclear if it is really needed (we normally don't), but it seems nice for our users to call the known issue out for a while. I'm okay with if these get deleted at a some later date. |
|
Thanks @gpshead for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jan 21, 2024
) The terminal CR -> NL mapping setting should be inherited in cbreak mode as OSes do not specify altering it as part of their stty cbreak mode definition. (cherry picked from commit fd49e22) Co-authored-by: Gregory P. Smith <[email protected]>
|
GH-114410 is a backport of this pull request to the 3.12 branch. |
gpshead
added a commit
that referenced
this pull request
Jan 21, 2024
…114410) The terminal CR -> NL mapping setting should be inherited in cbreak mode as OSes do not specify altering it as part of their stty cbreak mode definition. (cherry picked from commit fd49e22) Co-authored-by: Gregory P. Smith <[email protected]>
kulikjak
pushed a commit
to kulikjak/cpython
that referenced
this pull request
Jan 22, 2024
The terminal CR -> NL mapping setting should be inherited in cbreak mode as OSes do not specify altering it as part of their stty cbreak mode definition.
aisk
pushed a commit
to aisk/cpython
that referenced
this pull request
Feb 11, 2024
The terminal CR -> NL mapping setting should be inherited in cbreak mode as OSes do not specify altering it as part of their stty cbreak mode definition.
Glyphack
pushed a commit
to Glyphack/cpython
that referenced
this pull request
Sep 2, 2024
The terminal CR -> NL mapping setting should be inherited in cbreak mode as OSes do not specify altering it as part of their stty cbreak mode definition.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The terminal CR -> NL mapping setting should be inherited in cbreak mode as OSes do not specify altering it as part of their
sttycbreak mode definition.📚 Documentation preview 📚: https://cpython-previews--114335.org.readthedocs.build/