gh-114678: Fix incorrect deprecation warning for 'N' specifier in Decimal format #114683
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…in Decimal format Co-authored-by: Stefan Krah <[email protected]>
rhettinger
approved these changes
Jan 29, 2024
Contributor
|
I approved this but please still have Mark look at it as well. |
ericvsmith
approved these changes
Jan 29, 2024
Member
ericvsmith
left a comment
ericvsmith
left a comment
There was a problem hiding this comment.
One small point about the News entry, otherwise looks good to me.
Misc/NEWS.d/next/Library/2024-01-28-19-40-40.gh-issue-114678.kYKcJw.rst
Outdated
Show resolved
Hide resolved
ericvsmith
approved these changes
Jan 29, 2024
Member
|
I can't quite believe I missed this in the original PR. Apologies for that. |
|
Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12. |
|
Sorry, @serhiy-storchaka, I could not cleanly backport this to |
aisk
pushed a commit
to aisk/cpython
that referenced
this pull request
Feb 11, 2024
…in Decimal format (pythonGH-114683) Co-authored-by: Stefan Krah <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.