Revert "gh-96844: Improve error message of list.remove (gh-106455)" #116956
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
cc @corona10 |
Member
Author
|
See #116792 for the rationale of the revert. |
corona10
approved these changes
Mar 18, 2024
Member
|
It is pretty wired, it means that we can not use %R any other place for the same issue. |
erlend-aasland
approved these changes
Mar 18, 2024
Member
|
Next time, please include the reason for the revert in the commit message, per our guidelines. |
Member
Author
Oh, I don't know this guideline. I just used "git revert commit". Ok, will do next time. |
vstinner
added a commit
to vstinner/cpython
that referenced
this pull request
Mar 20, 2024
…h-106455)" (python#116956) This reverts commit 217f47d.
adorilson
pushed a commit
to adorilson/cpython
that referenced
this pull request
Mar 25, 2024
…h-106455)" (python#116956) This reverts commit 217f47d.
diegorusso
pushed a commit
to diegorusso/cpython
that referenced
this pull request
Apr 17, 2024
…h-106455)" (python#116956) This reverts commit 217f47d.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 217f47d.
📚 Documentation preview 📚: https://cpython-previews--116956.org.readthedocs.build/