Skip to content

Conversation

@miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Apr 10, 2024

(cherry picked from commit 4bb7d12)

Co-authored-by: Nikita Sobolev [email protected]
Co-authored-by: Alex Waygood [email protected]

…builtin_or_method` (pythonGH-117699)

(cherry picked from commit 4bb7d12)

Co-authored-by: Nikita Sobolev <[email protected]>
Co-authored-by: Alex Waygood <[email protected]>
@AlexWaygood
Copy link
Member

Hmm, looks like the @doctest_skip_if decorator doesn't exist on Python 3.12

@AlexWaygood AlexWaygood disabled auto-merge April 10, 2024 10:31
@AlexWaygood
Copy link
Member

Hmm, looks like the @doctest_skip_if decorator doesn't exist on Python 3.12

@sobolevn, reckon we should just backport the doctest_skip_if decorator to 3.12 as part of this PR? It seems pretty simple and low-risk

@sobolevn
Copy link
Member

See #116758 (comment)
I also thought that skipping this doctest would be easier, but the oirignal PR author had a valid point about doctest internals change in 3.13. We can go with if ...: in this branch.

@AlexWaygood AlexWaygood enabled auto-merge (squash) April 10, 2024 14:02
@AlexWaygood AlexWaygood merged commit 653ed76 into python:3.12 Apr 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants