bpo-35911: add cell constructor #11771
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pierreglaser
changed the title
pitrou
approved these changes
Feb 6, 2019
Member
pitrou
left a comment
pitrou
left a comment
There was a problem hiding this comment.
+1, looks like a no-brainer to me.
Will wait a bit for other core devs. Feel free to ping in a few days if no other feedback comes.
Member
ncoghlan
approved these changes
Feb 7, 2019
Contributor
ncoghlan
left a comment
ncoghlan
left a comment
There was a problem hiding this comment.
LGTM. May be worth updating https://docs.python.org/3/reference/datamodel.html#the-standard-type-hierarchy to cross-link the new type when it mentions cell_contents.
Member
|
Thanks @pierreglaser ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bpo-35911: Add a
cellconstructorThis PR adds:
cell.__new__method, with an optionalcontentsarguments.celltype in theLib/types.pymodule, under the nameCellTypeAdditional docs and tests are also provided.
The rationale behind this PR is explained in detail in the corresponding bpo issue.
https://bugs.python.org/issue35911