Skip to content

[3.4] bpo-34656: Avoid relying on signed overflow in _pickle memos (GH-9261) #11870

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
larryhastings merged 3 commits into from
Feb 25, 2019
Merged

[3.4] bpo-34656: Avoid relying on signed overflow in _pickle memos (GH-9261) #11870

larryhastings merged 3 commits into from
Feb 25, 2019

Conversation

@vstinner
Copy link
Member

@vstinner vstinner commented Feb 15, 2019 •
edited by bedevere-bot
Loading

(cherry picked from commit a4ae828)

https://bugs.python.org/issue34656

@vstinner
Copy link
Member Author

vstinner commented Feb 15, 2019

Please double-check this one, I had to fix compilation error on Windows (second commit). cc @mcepl

@mcepl
Copy link
Contributor

mcepl commented Feb 15, 2019

Yeah, it looks sensible. I had the same problem with Windows compilers myself many times. +1 from me.

@vstinner
Copy link
Member Author

vstinner commented Feb 15, 2019

Yeah, it looks sensible. I had the same problem with Windows compilers myself many times. +1 from me.

Can you please officially "approve" the change?

@vstinner
Copy link
Member Author

vstinner commented Feb 15, 2019

AppVeyor build succeeded

Aha, my 2nd commit fixed compilation on Windows (and tests pass).

@mcepl
Copy link
Contributor

mcepl commented Feb 15, 2019

Yeah, it looks sensible. I had the same problem with Windows compilers myself many times. +1 from me.

Can you please officially "approve" the change?

I don't see the button anywhere. I don't think I have any bits required.

@vstinner
Copy link
Member Author

vstinner commented Feb 15, 2019

I don't see the button anywhere. I don't think I have any bits required.

Anyone can approve/reject a change: go to the "Files changes" tab and click on [Review changes] button, then select (o) Approve.

mcepl
mcepl approved these changes Feb 15, 2019
View reviewed changes
Copy link
Contributor

@mcepl mcepl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is basically my original patch (which is running in openSUSE) with additional fixes for Windows compilation. Looks good.

@mcepl
Copy link
Contributor

mcepl commented Feb 15, 2019

Like this?

@vstinner
Copy link
Member Author

vstinner commented Feb 15, 2019

Like this?

Yes! Thanks :-)

@larryhastings larryhastings merged commit 4b42d57 into python:3.4 Feb 25, 2019
@bedevere-bot
Copy link

bedevere-bot commented Feb 25, 2019

@larryhastings: Please replace # with GH- in the commit message next time. Thanks!

@larryhastings
Copy link
Contributor

larryhastings commented Feb 25, 2019

Thanks for the backport!

@vstinner vstinner deleted the pickle_load34 branch April 29, 2019 14:01
@httpsgithubcomxcainiao httpsgithubcomxcainiao mannequin mentioned this pull request Apr 10, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gpshead gpshead gpshead approved these changes

+1 more reviewer

@mcepl mcepl mcepl approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@vstinner @mcepl @bedevere-bot @larryhastings @gpshead @the-knights-who-say-ni @benjaminp