JIT: ignore some failing test_logging tests #120375
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some of the test_logging tests are failing in the emulated linux environment on GitHub indipendently from the changes of the PR Add them to the ignore list.
diegorusso
force-pushed
the
jit-ignore-test-logging-tests
branch
from
bd83a2d to
b38a313
Compare
diegorusso
commented
Jun 11, 2024
| test.test_subprocess.ProcessTestCaseNoPoll.test_file_not_found_includes_filename | ||
| test.test_subprocess.ProcessTestCaseNoPoll.test_one_environment_variable | ||
| test.test_venv.BasicTest.test_zippath_from_non_installed_posix | ||
| test.test_venv.BasicTest.test_zippath_from_non_installed_posix |
Contributor
Author
There was a problem hiding this comment.
My editor added automatically the new line at the end of the file.
brandtbucher
added
type-bug
Contributor
|
Thanks, the failed workflow notifications were getting annoying. |
|
Thanks @diegorusso for the PR, and @brandtbucher for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jun 24, 2024
(cherry picked from commit 07daaf1) Co-authored-by: Diego Russo <[email protected]>
|
GH-120977 is a backport of this pull request to the 3.13 branch. |
mrahtz
pushed a commit
to mrahtz/cpython
that referenced
this pull request
Jun 30, 2024
noahbkim
pushed a commit
to hudson-trading/cpython
that referenced
this pull request
Jul 11, 2024
estyxx
pushed a commit
to estyxx/cpython
that referenced
this pull request
Jul 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of the test_logging tests are failing in the emulated linux environment on GitHub independently from the changes of the PR. Add them to the ignore list.