gh-120659: Skip test_freethreading with GIL
#120660
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colesbury
reviewed
Jun 17, 2024
vstinner
reviewed
Jun 18, 2024
Co-authored-by: Victor Stinner <[email protected]>
nineteendo
force-pushed
the
skip-test_freethreading-gil
branch
from
d5633ae to
465759a
Compare
Contributor
Author
|
I fixed the co-author message. |
Member
I don't know test_freethreading. I don't know if it makes sense to run these tests with the GIL enabled. |
This comment was marked as resolved.
This comment was marked as resolved.
Contributor
|
There is some value to running these tests on with the GIL enabled, but not enough to justify the time they're taking. If we make the tests faster, we can reconsider re-enabling them for the default build. |
colesbury
approved these changes
Jun 18, 2024
|
Thanks @nineteendo for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jun 18, 2024
(cherry picked from commit 360f14a) Co-authored-by: Nice Zombies <[email protected]>
|
GH-120694 is a backport of this pull request to the 3.13 branch. |
Member
|
Ok, in that case, I merge the change. Thanks @nineteendo. |
vstinner
pushed a commit
that referenced
this pull request
Jun 18, 2024
…0694) gh-120659: Skip `test_freethreading` with GIL (GH-120660) (cherry picked from commit 360f14a) Co-authored-by: Nice Zombies <[email protected]>
picnixz
pushed a commit
to picnixz/cpython
that referenced
this pull request
Jun 19, 2024
mrahtz
pushed a commit
to mrahtz/cpython
that referenced
this pull request
Jun 30, 2024
noahbkim
pushed a commit
to hudson-trading/cpython
that referenced
this pull request
Jul 11, 2024
estyxx
pushed a commit
to estyxx/cpython
that referenced
this pull request
Jul 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test_free_threadingwith GIL #120659