gh-121245: Amend d611c4c8e9 (correct import) #121255
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This prevents writing incorrect history (empty).
Contributor
Author
|
CC @pablogsal |
vstinner
reviewed
Jul 2, 2024
vstinner
approved these changes
Jul 2, 2024
Member
vstinner
left a comment
vstinner
left a comment
There was a problem hiding this comment.
LGTM if you remove the comment.
skirpichev
changed the title
skirpichev
commented
Jul 2, 2024
Contributor
Author
|
BTW, test in write_history() looks asymmetrical wrt reading the history file. Maybe it should be moved up to fill some variable like That wasn't included, I did just minimal changes. Edit: title was corrected, now its referenced commit in the main, not on 3.13. |
hroncok
reviewed
Jul 2, 2024
Misc/NEWS.d/next/Library/2024-07-02-11-34-06.gh-issue-121245.sSkDAr.rst
Outdated
Show resolved
Hide resolved
…SkDAr.rst Co-authored-by: Miro Hrončok <[email protected]>
hroncok
approved these changes
Jul 2, 2024
|
Thanks @skirpichev for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13. |
hroncok
added a commit
to fedora-python/cpython
that referenced
this pull request
Jul 2, 2024
Co-authored-by: Miro Hrončok <[email protected]>
ambv
added
needs backport to 3.13
|
Thanks @skirpichev for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jul 2, 2024
(cherry picked from commit 7a807c3) Co-authored-by: Sergey B Kirpichev <[email protected]> Co-authored-by: Miro Hrončok <[email protected]>
|
GH-121261 is a backport of this pull request to the 3.13 branch. |
lysnikolaou
pushed a commit
that referenced
this pull request
Jul 2, 2024
(cherry picked from commit 7a807c3) Co-authored-by: Sergey B Kirpichev <[email protected]> Co-authored-by: Miro Hrončok <[email protected]>
Akasurde
pushed a commit
to Akasurde/cpython
that referenced
this pull request
Jul 3, 2024
Co-authored-by: Miro Hrončok <[email protected]>
noahbkim
pushed a commit
to hudson-trading/cpython
that referenced
this pull request
Jul 11, 2024
Co-authored-by: Miro Hrončok <[email protected]>
estyxx
pushed a commit
to estyxx/cpython
that referenced
this pull request
Jul 17, 2024
Co-authored-by: Miro Hrončok <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prevents writing incorrect history (empty).
Fixed by @domdfcoding.