gh-119698: deprecate symtable.Class.get_methods
#121902
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZeroIntensity
approved these changes
Jul 17, 2024
Member
ZeroIntensity
left a comment
ZeroIntensity
left a comment
There was a problem hiding this comment.
LGTM, but I'm not too sure about the import warnings in the method body instead of at the module level. I'll let a core dev decide on that.
serhiy-storchaka
approved these changes
Jul 17, 2024
Member
Author
|
Friendly ping @JelleZijlstra in case you forgot about this one (or maybe if you were not aware of it). |
JelleZijlstra
approved these changes
Jul 22, 2024
Member
JelleZijlstra
left a comment
JelleZijlstra
left a comment
There was a problem hiding this comment.
Thanks, hadn't seen this PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deprecation notice for
symtable.Class.get_methodsfor 3.14+ (to be merged after #121802 since it is included in this PR).📚 Documentation preview 📚: https://cpython-previews--121902.org.readthedocs.build/