Skip to content

Conversation

@miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Jul 25, 2024

(cherry picked from commit a3327db)

Co-authored-by: Mikołaj Kuranowski [email protected]

@hugovk
Copy link
Member

hugovk commented Aug 9, 2024

@serhiy-storchaka This didn't automerge because test_csv is failing on the CI:

======================================================================
FAIL: test_read_quoting (test.test_csv.Test_Csv.test_read_quoting)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/Users/admin/actions-runner/_work/cpython/cpython/Lib/test/test_csv.py", line 428, in test_read_quoting
    self._read_test(['1\\.5,\\.5,.5'], [[1.5, 0.5, 0.5]],
  File "/Users/admin/actions-runner/_work/cpython/cpython/Lib/test/test_csv.py", line 354, in _read_test
    self.assertEqual(result, expect)
AssertionError: Lists differ: [[1.5, '.5', 0.5]] != [[1.5, 0.5, 0.5]]

First differing element 0:
[1.5, '.5', 0.5]
[1.5, 0.5, 0.5]

- [[1.5, '.5', 0.5]]
?        ^  -

+ [[1.5, 0.5, 0.5]]
?        ^

@serhiy-storchaka
Copy link
Member

Oh yes. It depended on #113732. It is possible to resolve this issue without touching that change. But It may be safer to not backport this change to 3.12.

@serhiy-storchaka serhiy-storchaka merged commit 9d7209f into python:3.12 Aug 9, 2024
@serhiy-storchaka
Copy link
Member

Oh, I did not mean to merge it now. Well, it doesn't matter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

tests Tests in the Lib/test dir

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants