gh-122332: Fix missing NULL check in asyncio.Task.get_coro
#122338
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
ZeroIntensity
commented
Jul 27, 2024
ZeroIntensity
commented
- Issue: Eager task factory segfaults when hosting and calling an API from the same event loop #122332
ZeroIntensity
requested review from
1st1,
asvetlov,
gvanrossum,
kumaraditya303 and
willingc
as code owners
Member
JelleZijlstra
left a comment
JelleZijlstra
left a comment
There was a problem hiding this comment.
Could you add a unit test for this? Something that would currently segfault.
Co-authored-by: Jelle Zijlstra <[email protected]>
Member
Author
Added it, it's basically a translation of my reproducer in #122332. |
Eclips4
added
needs backport to 3.12
kumaraditya303
approved these changes
Jul 27, 2024
|
Thanks @ZeroIntensity for the PR, and @kumaraditya303 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jul 27, 2024
…ythonGH-122338) (cherry picked from commit c086962) Co-authored-by: Peter Bierma <[email protected]>
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jul 27, 2024
…ythonGH-122338) (cherry picked from commit c086962) Co-authored-by: Peter Bierma <[email protected]>
|
GH-122344 is a backport of this pull request to the 3.13 branch. |
|
GH-122345 is a backport of this pull request to the 3.12 branch. |
kumaraditya303
pushed a commit
that referenced
this pull request
Jul 27, 2024
…GH-122338) (#122345) gh-122332: Fix missing `NULL` check in `asyncio.Task.get_coro` (GH-122338) (cherry picked from commit c086962) Co-authored-by: Peter Bierma <[email protected]>
kumaraditya303
pushed a commit
that referenced
this pull request
Jul 27, 2024
…GH-122338) (#122344) gh-122332: Fix missing `NULL` check in `asyncio.Task.get_coro` (GH-122338) (cherry picked from commit c086962) Co-authored-by: Peter Bierma <[email protected]>
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
