Skip to content

Conversation

@vstinner
Copy link
Member

@vstinner vstinner commented Aug 9, 2024

@vstinner
Copy link
Member Author

vstinner commented Aug 9, 2024

cc @pitrou @encukou

Copy link
Contributor

@erlend-aasland erlend-aasland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you intend to update Misc/stable_abi.toml also?

Copy link
Member

@encukou encukou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! This looks good, but, wasn't the name supposed to be Py_HashBuffer?

@vstinner vstinner changed the title gh-122854: Add Py_HashBytes() function gh-122854: Add Py_HashBuffer() function Aug 26, 2024
@vstinner
Copy link
Member Author

vstinner commented Aug 26, 2024

Thank you! This looks good, but, wasn't the name capi-workgroup/decisions#13 (comment)?

Oh, you're right! I modified the PR to use Py_HashBuffer(). I also rebased the PR to fix a merge conflict.

Copy link
Member

@encukou encukou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With Erlend's suggestions, this should be good to merge!

@vstinner
Copy link
Member Author

With Erlend's suggestions, this should be good to merge!

Fixed. Oh, I thought that I already addressed his review, but it was maybe on another similar PR.

I also replaced hash_bytes() with hash_buffer() in tests. Nicely spotted @encukou.

@vstinner
Copy link
Member Author

@erlend-aasland:

Did you intend to update Misc/stable_abi.toml also?

capi-workgroup/decisions#13 doesn't mention the stable ABI. Do you think that this API should be added to the stable ABI?

@vstinner vstinner enabled auto-merge (squash) August 30, 2024 15:19
@vstinner
Copy link
Member Author

@erlend-aasland: I enabled auto-merge. If you consider that the function should be added to the limited C API 3.14, I can prepare a follow-up PR.

@vstinner vstinner merged commit d8e69b2 into python:main Aug 30, 2024
@vstinner vstinner deleted the hashbytes branch August 30, 2024 15:42
@vstinner
Copy link
Member Author

Merged, thanks for reviews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants