-
-
Notifications
You must be signed in to change notification settings - Fork 33.7k
gh-122854: Add Py_HashBuffer() function #122855
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
erlend-aasland
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you intend to update Misc/stable_abi.toml also?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! This looks good, but, wasn't the name supposed to be Py_HashBuffer?
Oh, you're right! I modified the PR to use Py_HashBuffer(). I also rebased the PR to fix a merge conflict. |
encukou
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With Erlend's suggestions, this should be good to merge!
Fixed. Oh, I thought that I already addressed his review, but it was maybe on another similar PR. I also replaced hash_bytes() with hash_buffer() in tests. Nicely spotted @encukou. |
capi-workgroup/decisions#13 doesn't mention the stable ABI. Do you think that this API should be added to the stable ABI? |
|
@erlend-aasland: I enabled auto-merge. If you consider that the function should be added to the limited C API 3.14, I can prepare a follow-up PR. |
|
Merged, thanks for reviews. |
📚 Documentation preview 📚: https://cpython-previews--122855.org.readthedocs.build/