bpo-28866: No type cache for types with specialized mro, invalidation is hard. #13157
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markshannon
reviewed
May 7, 2019
ZackerySpytz
reviewed
May 7, 2019
markshannon
reviewed
May 8, 2019
| _Py_IDENTIFIER(mro); | ||
| int unbound; | ||
| PyObject *mro_meth = lookup_maybe_method( | ||
| (PyObject *)type, &PyId_mro, &unbound); |
Member
There was a problem hiding this comment.
mro_meth needs to be checked for NULL before lookup_maybe_method is called again.
Member
Author
There was a problem hiding this comment.
OK :-] is using a goto legit here? It'll avoid a bunch of if (clear == 0) (see current impl).
markshannon
reviewed
May 18, 2019
Member
|
LGTM |
|
@markshannon: Please replace |
Contributor
|
Thanks @JulienPalard for the PR, and @markshannon for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7. |
|
GH-13589 is a backport of this pull request to the 3.7 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
May 26, 2019
… is hard. (pythonGH-13157) * No type cache for types with specialized mro, invalidation is hard. * FIX: Don't disable method cache custom types that do not implement mro(). * fixing implem. * Avoid storing error flags, also decref. * news entry * Clear as soon as we're getting an error. * FIX: Reference leak. (cherry picked from commit 180dc1b) Co-authored-by: Julien Palard <[email protected]>
miss-islington
added a commit
that referenced
this pull request
May 26, 2019
…dation is hard. (GH-13157) (GH-13589) * No type cache for types with specialized mro, invalidation is hard. * FIX: Don't disable method cache custom types that do not implement mro(). * fixing implem. * Avoid storing error flags, also decref. * news entry * Clear as soon as we're getting an error. * FIX: Reference leak. (cherry picked from commit 180dc1b) Co-authored-by: Julien Palard <[email protected]> https://bugs.python.org/issue28866
DinoV
pushed a commit
to DinoV/cpython
that referenced
this pull request
Jan 14, 2020
… is hard. (python#13157) * No type cache for types with specialized mro, invalidation is hard. * FIX: Don't disable method cache custom types that do not implement mro(). * fixing implem. * Avoid storing error flags, also decref. * news entry * Clear as soon as we're getting an error. * FIX: Reference leak.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an alternative implementation of #13117 based on @markshannon idea (https://bugs.python.org/issue28866#msg341581).
https://bugs.python.org/issue28866