gh-131853: test binary header in `msgfmt` generated file #131854

StanFromIreland · 2025-03-28T16:27:08Z

skip-news please this is just a test change

Issue: msgfmt.py: Test validity of generated file #131853

StanFromIreland · 2025-03-28T16:30:22Z

request: @tomasr8 @serhiy-storchaka

Lib/test/test_tools/test_msgfmt.py

bedevere-bot · 2025-03-29T12:35:18Z

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot s390x RHEL8 3.x (tier-3) has failed when building commit fccf9ab.

What do you need to do:

Don't panic.
Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/509/builds/8786) and take a look at the build logs.
Check if the failure is related to this commit (fccf9ab) or if it is a false positive.
If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/509/builds/8786

Failed tests:

test_tools

Failed subtests:

test_binary_header - test.test_tools.test_msgfmt.CompilationTest.test_binary_header

Summary of the results of the build (if available):

==

Click to see traceback logs

Traceback (most recent call last):
  File "/home/buildbot/buildarea/3.x.cstratak-rhel8-s390x/build/Lib/test/test_tools/test_msgfmt.py", line 58, in test_binary_header
    self.assertEqual(magic, 0x950412de)
    ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^
AssertionError: 3725722773 != 2500072158

bedevere-bot · 2025-03-29T12:40:13Z

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot s390x RHEL9 3.x (tier-3) has failed when building commit fccf9ab.

What do you need to do:

Don't panic.
Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/1565/builds/1752) and take a look at the build logs.
Check if the failure is related to this commit (fccf9ab) or if it is a false positive.
If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/1565/builds/1752

Failed tests:

test_tools

Failed subtests:

test_binary_header - test.test_tools.test_msgfmt.CompilationTest.test_binary_header

Summary of the results of the build (if available):

==

Click to see traceback logs

Traceback (most recent call last):
  File "/home/buildbot/buildarea/3.x.cstratak-rhel9-s390x/build/Lib/test/test_tools/test_msgfmt.py", line 58, in test_binary_header
    self.assertEqual(magic, 0x950412de)
    ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^
AssertionError: 3725722773 != 2500072158

StanFromIreland · 2025-03-29T12:47:40Z

@tomasr8 We shouldn't have added the =, s390x is big endian

bedevere-bot · 2025-03-29T12:48:33Z

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot s390x RHEL8 LTO + PGO 3.x (tier-3) has failed when building commit fccf9ab.

What do you need to do:

Don't panic.
Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/442/builds/8877) and take a look at the build logs.
Check if the failure is related to this commit (fccf9ab) or if it is a false positive.
If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/442/builds/8877

Failed tests:

test_tools

Failed subtests:

test_binary_header - test.test_tools.test_msgfmt.CompilationTest.test_binary_header

Summary of the results of the build (if available):

==

Click to see traceback logs

Traceback (most recent call last):
  File "/home/buildbot/buildarea/3.x.cstratak-rhel8-s390x.lto-pgo/build/Lib/test/test_tools/test_msgfmt.py", line 58, in test_binary_header
    self.assertEqual(magic, 0x950412de)
    ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^
AssertionError: 3725722773 != 2500072158

serhiy-storchaka · 2025-03-29T12:53:09Z

Oh, there is an issue with ending.

This test should use a just generated file, not a checked in binary file.

bedevere-bot · 2025-03-29T12:55:18Z

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot s390x RHEL9 LTO + PGO 3.x (tier-3) has failed when building commit fccf9ab.

What do you need to do:

Don't panic.
Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/1578/builds/1758) and take a look at the build logs.
Check if the failure is related to this commit (fccf9ab) or if it is a false positive.
If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/1578/builds/1758

Failed tests:

test_tools

Failed subtests:

test_binary_header - test.test_tools.test_msgfmt.CompilationTest.test_binary_header

Summary of the results of the build (if available):

==

Click to see traceback logs

Traceback (most recent call last):
  File "/home/buildbot/buildarea/3.x.cstratak-rhel9-s390x.lto-pgo/build/Lib/test/test_tools/test_msgfmt.py", line 58, in test_binary_header
    self.assertEqual(magic, 0x950412de)
    ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^
AssertionError: 3725722773 != 2500072158

bedevere-bot · 2025-03-29T12:56:53Z

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot s390x RHEL8 LTO 3.x (tier-3) has failed when building commit fccf9ab.

What do you need to do:

Don't panic.
Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/567/builds/8793) and take a look at the build logs.
Check if the failure is related to this commit (fccf9ab) or if it is a false positive.
If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/567/builds/8793

Failed tests:

test_tools

Failed subtests:

test_binary_header - test.test_tools.test_msgfmt.CompilationTest.test_binary_header

Summary of the results of the build (if available):

==

Click to see traceback logs

Traceback (most recent call last):
  File "/home/buildbot/buildarea/3.x.cstratak-rhel8-s390x.lto/build/Lib/test/test_tools/test_msgfmt.py", line 58, in test_binary_header
    self.assertEqual(magic, 0x950412de)
    ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^
AssertionError: 3725722773 != 2500072158

StanFromIreland · 2025-03-29T12:58:12Z

@serhiy-storchaka What do you want to do, how do we want to deal with big-endian systems?

bedevere-bot · 2025-03-29T13:03:51Z

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot s390x RHEL9 LTO 3.x (tier-3) has failed when building commit fccf9ab.

What do you need to do:

Don't panic.
Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/1587/builds/1764) and take a look at the build logs.
Check if the failure is related to this commit (fccf9ab) or if it is a false positive.
If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/1587/builds/1764

Failed tests:

test_tools

Failed subtests:

test_binary_header - test.test_tools.test_msgfmt.CompilationTest.test_binary_header

Summary of the results of the build (if available):

==

Click to see traceback logs

Traceback (most recent call last):
  File "/home/buildbot/buildarea/3.x.cstratak-rhel9-s390x.lto/build/Lib/test/test_tools/test_msgfmt.py", line 58, in test_binary_header
    self.assertEqual(magic, 0x950412de)
    ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^
AssertionError: 3725722773 != 2500072158

serhiy-storchaka · 2025-03-29T13:10:18Z

See #131854.

StanFromIreland · 2025-03-29T13:12:38Z

I can't edit so correction: #131879

bedevere-bot · 2025-03-29T13:49:10Z

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot s390x Fedora Stable 3.x (tier-3) has failed when building commit fccf9ab.

What do you need to do:

Don't panic.
Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/1636/builds/27) and take a look at the build logs.
Check if the failure is related to this commit (fccf9ab) or if it is a false positive.
If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/1636/builds/27

Failed tests:

test_tools

Failed subtests:

test_binary_header - test.test_tools.test_msgfmt.CompilationTest.test_binary_header

Summary of the results of the build (if available):

==

Click to see traceback logs

Traceback (most recent call last):
  File "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-s390x/build/Lib/test/test_tools/test_msgfmt.py", line 58, in test_binary_header
    self.assertEqual(magic, 0x950412de)
    ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^
AssertionError: 3725722773 != 2500072158

bedevere-bot · 2025-03-29T13:54:19Z

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot s390x Fedora Stable Clang 3.x (tier-3) has failed when building commit fccf9ab.

What do you need to do:

Don't panic.
Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/1670/builds/27) and take a look at the build logs.
Check if the failure is related to this commit (fccf9ab) or if it is a false positive.
If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/1670/builds/27

Failed tests:

test_tools

Failed subtests:

test_binary_header - test.test_tools.test_msgfmt.CompilationTest.test_binary_header

Summary of the results of the build (if available):

==

Click to see traceback logs

Traceback (most recent call last):
  File "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-s390x.clang/build/Lib/test/test_tools/test_msgfmt.py", line 58, in test_binary_header
    self.assertEqual(magic, 0x950412de)
    ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^
AssertionError: 3725722773 != 2500072158

bedevere-bot · 2025-03-29T14:16:37Z

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot s390x Fedora Stable LTO + PGO 3.x (tier-3) has failed when building commit fccf9ab.

What do you need to do:

Don't panic.
Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/1627/builds/27) and take a look at the build logs.
Check if the failure is related to this commit (fccf9ab) or if it is a false positive.
If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/1627/builds/27

Failed tests:

test_tools

Failed subtests:

test_binary_header - test.test_tools.test_msgfmt.CompilationTest.test_binary_header
test_timerfd_ns_poll - test.test_os.TimerfdTests.test_timerfd_ns_poll
test_timerfd_select - test.test_os.TimerfdTests.test_timerfd_select

Summary of the results of the build (if available):

==

Click to see traceback logs

Traceback (most recent call last):
  File "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-s390x.lto-pgo/build/Lib/test/test_os.py", line 4512, in test_timerfd_ns_poll
    self.check_timerfd_poll(True)
    ~~~~~~~~~~~~~~~~~~~~~~~^^^^^^
  File "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-s390x.lto-pgo/build/Lib/test/test_os.py", line 4497, in check_timerfd_poll
    self.assertEqual(self.read_count_signaled(fd), 1)
    ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AssertionError: 4 != 1


Traceback (most recent call last):
  File "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-s390x.lto-pgo/build/Lib/test/test_os.py", line 4452, in test_timerfd_select
    self.assertEqual(self.read_count_signaled(fd), 1)
    ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AssertionError: 3 != 1


Traceback (most recent call last):
  File "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-s390x.lto-pgo/build/Lib/test/test_tools/test_msgfmt.py", line 58, in test_binary_header
    self.assertEqual(magic, 0x950412de)
    ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^
AssertionError: 3725722773 != 2500072158

bedevere-bot · 2025-03-29T14:26:22Z

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot s390x Fedora Stable LTO 3.x (tier-3) has failed when building commit fccf9ab.

What do you need to do:

Don't panic.
Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/1654/builds/27) and take a look at the build logs.
Check if the failure is related to this commit (fccf9ab) or if it is a false positive.
If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/1654/builds/27

Failed tests:

test_tools

Failed subtests:

test_binary_header - test.test_tools.test_msgfmt.CompilationTest.test_binary_header

Summary of the results of the build (if available):

==

Click to see traceback logs

Traceback (most recent call last):
  File "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-s390x.lto/build/Lib/test/test_tools/test_msgfmt.py", line 58, in test_binary_header
    self.assertEqual(magic, 0x950412de)
    ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^
AssertionError: 3725722773 != 2500072158

bedevere-bot · 2025-03-29T14:44:50Z

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot s390x RHEL9 Refleaks 3.x (tier-3) has failed when building commit fccf9ab.

What do you need to do:

Don't panic.
Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/1589/builds/1197) and take a look at the build logs.
Check if the failure is related to this commit (fccf9ab) or if it is a false positive.
If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/1589/builds/1197

Failed tests:

test_tools

Failed subtests:

test_binary_header - test.test_tools.test_msgfmt.CompilationTest.test_binary_header

Summary of the results of the build (if available):

==

Click to see traceback logs

Traceback (most recent call last):
  File "/home/buildbot/buildarea/3.x.cstratak-rhel9-s390x.refleak/build/Lib/test/test_tools/test_msgfmt.py", line 58, in test_binary_header
    self.assertEqual(magic, 0x950412de)
    ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^
AssertionError: 3725722773 != 2500072158

Add test

8213a01

bedevere-app bot added tests Tests in the Lib/test dir awaiting review labels Mar 28, 2025

bedevere-app bot mentioned this pull request Mar 28, 2025

msgfmt.py: Test validity of generated file #131853

Closed

picnixz added the skip news label Mar 28, 2025

picnixz changed the title ~~gh-131853: Test binary header in generated file~~ gh-131853: test binary header in msgfmt generated file Mar 28, 2025

tomasr8 reviewed Mar 28, 2025

View reviewed changes

Lib/test/test_tools/test_msgfmt.py Outdated Show resolved Hide resolved

Tomas's feedback

c005eb0

StanFromIreland requested a review from tomasr8 March 28, 2025 20:29

serhiy-storchaka approved these changes Mar 29, 2025

View reviewed changes

bedevere-app bot added awaiting merge and removed awaiting review labels Mar 29, 2025

serhiy-storchaka merged commit fccf9ab into python:main Mar 29, 2025
42 checks passed

bedevere-app bot removed the awaiting merge label Mar 29, 2025

StanFromIreland deleted the msgfmt-tests branch March 29, 2025 13:55

Uh oh!

gh-131853: test binary header in msgfmt generated file #131854

gh-131853: test binary header in msgfmt generated file #131854

Uh oh!

Conversation

StanFromIreland commented Mar 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

StanFromIreland commented Mar 28, 2025

Uh oh!

Uh oh!

Uh oh!

bedevere-bot commented Mar 29, 2025

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Uh oh!

bedevere-bot commented Mar 29, 2025

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Uh oh!

StanFromIreland commented Mar 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bedevere-bot commented Mar 29, 2025

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Uh oh!

serhiy-storchaka commented Mar 29, 2025

Uh oh!

bedevere-bot commented Mar 29, 2025

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Uh oh!

bedevere-bot commented Mar 29, 2025

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Uh oh!

StanFromIreland commented Mar 29, 2025

Uh oh!

bedevere-bot commented Mar 29, 2025

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Uh oh!

serhiy-storchaka commented Mar 29, 2025

Uh oh!

StanFromIreland commented Mar 29, 2025

Uh oh!

bedevere-bot commented Mar 29, 2025

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Uh oh!

bedevere-bot commented Mar 29, 2025

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Uh oh!

bedevere-bot commented Mar 29, 2025

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Uh oh!

bedevere-bot commented Mar 29, 2025

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Uh oh!

bedevere-bot commented Mar 29, 2025

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

gh-131853: test binary header in `msgfmt` generated file #131854

gh-131853: test binary header in `msgfmt` generated file #131854

StanFromIreland commented Mar 28, 2025 •

edited

Loading

StanFromIreland commented Mar 29, 2025 •

edited

Loading