gh-134584: Eliminate redundant refcounting from _CALL_LEN
#136104
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
corona10
requested review from
Fidget-Spinner,
markshannon and
tomasr8
as code owners
32 tasks
Member
|
Thanks! We need to wait until Mark's TOS caching PR is merged for this to be a speedup (I explained on the main issue), so lets wait for now. |
This reverts commit afd5bb0.
Fidget-Spinner
approved these changes
Dec 11, 2025
Member
Fidget-Spinner
left a comment
Fidget-Spinner
left a comment
There was a problem hiding this comment.
LGTM. Could you please re-run make regen-cases on this after merging main in?
You can merge after.
Python/bytecodes.c
Outdated
| /* len(o) */ | ||
| (void)null; | ||
| STAT_INC(CALL, hit); | ||
| INPUTS_DEAD(); |
Member
There was a problem hiding this comment.
This should be moved down to right before res = PyStackRef_FromPyObjectSteal(res_o);
Member
Author
|
@Fidget-Spinner Done :) |
Member
|
@corona10 sorry I just noticed something else wrong, once you fix that you can merge. Thanks! |
Fidget-Spinner
added a commit
to Fidget-Spinner/cpython
that referenced
this pull request
Dec 11, 2025
Fidget-Spinner
added a commit
to Fidget-Spinner/cpython
that referenced
this pull request
Dec 11, 2025
fatelei
pushed a commit
to fatelei/cpython
that referenced
this pull request
Dec 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.