gh-138697: Fix inferring dest from a single-dash long option in argparse #138699
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… argparse If a short option and a single-dash long option are passed to add_argument(), dest is now inferred from the single-dash long option.
serhiy-storchaka
force-pushed
the
argparse-single-dash-long-option-dest
branch
from
9987fa1 to
426169f
Compare
savannahostrowski
requested changes
Nov 20, 2025
Member
savannahostrowski
left a comment
savannahostrowski
left a comment
There was a problem hiding this comment.
Overall, I am supportive of making dest more consistent so thanks for opening this issue and PR. However, there is one edge case that still needs to be addressed.
|
When you're done making the requested changes, leave the comment: |
Member
Author
|
I have made the requested changes; please review again. |
|
Thanks for making the requested changes! @savannahostrowski: please review the changes made to this pull request. |
savannahostrowski
approved these changes
Nov 20, 2025
Member
savannahostrowski
left a comment
savannahostrowski
left a comment
There was a problem hiding this comment.
LGTM! Thanks for this!
StanFromIreland
pushed a commit
to StanFromIreland/cpython
that referenced
this pull request
Dec 6, 2025
… argparse (python#138699) * pythongh-138697: Fix inferring dest from a single-dash long option in argparse If a short option and a single-dash long option are passed to add_argument(), dest is now inferred from the single-dash long option. * Make double-dash options taking priority over single-dash long options. --------- Co-authored-by: Savannah Ostrowski <[email protected]>
ashm-dev
pushed a commit
to ashm-dev/cpython
that referenced
this pull request
Dec 8, 2025
… argparse (python#138699) * pythongh-138697: Fix inferring dest from a single-dash long option in argparse If a short option and a single-dash long option are passed to add_argument(), dest is now inferred from the single-dash long option. * Make double-dash options taking priority over single-dash long options. --------- Co-authored-by: Savannah Ostrowski <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a short option and a single-dash long option are passed to add_argument(), dest is now inferred from the single-dash long option.
📚 Documentation preview 📚: https://cpython-previews--138699.org.readthedocs.build/