gh-140210: Make test_sysconfig.test_parse_makefile_renamed_vars ignore environment variables #140213
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… ignore environment variables The test did not expect it could be run with e.g. CFLAGS set to a custom value. Fixes python#140210
vstinner
approved these changes
Oct 16, 2025
Member
vstinner
left a comment
vstinner
left a comment
There was a problem hiding this comment.
LGTM.
I confirm that I can easily reproduce the issue by setting CFLAGS environment variable:
$ CFLAGS="xxx" ./python -m test test_sysconfig -m test_parse_makefile_renamed_vars -v
...
- 'var1': 'xxx',
? ^^^
+ 'var1': '-Wall',
? ^^^^^
...
With this PR, I can no longer reproduce the issue.
brettcannon
approved these changes
Nov 27, 2025
Contributor
Author
|
Thanks for merging. |
Member
|
Oh sorry, I forgot to merge this PR. |
Contributor
Author
|
I forgot I opened it, so I think it's fine :D |
StanFromIreland
pushed a commit
to StanFromIreland/cpython
that referenced
this pull request
Dec 6, 2025
… ignore environment variables (python#140213) The test did not expect it could be run with e.g. CFLAGS set to a custom value.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test did not expect it could be run with e.g. CFLAGS set to a custom value.
Fixes #140210