-
-
Notifications
You must be signed in to change notification settings - Fork 33.7k
gh-140790: pdb: Initialize instance variables in Pdb.__init__ #140791
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Carreau
commented
Oct 31, 2025
Carreau
commented
Oct 31, 2025
Initialize lineno, stack, curindex, curframe, currentbp, and _user_requested_quit attributes in `Pdb.__init__`` instead of at first use. This ensures these attributes are always defined and allows removal of defensive getattr/hasattr checks throughout the codebase. In particular for a custom PDB subclass in IPython, the need to use a getattr has performance implications, and while we could set it our `__init__` it was easy to send a more global patch to CPython. Should fix pythongh-140790
gaogaotiantian
approved these changes
Nov 14, 2025
|
Member
|
The buildbot alert seems to be irrelevant. |
Contributor
Author
|
Thank you for the review and the merge! |
StanFromIreland
pushed a commit
to StanFromIreland/cpython
that referenced
this pull request
Dec 6, 2025
…ython#140791) Initialize lineno, stack, curindex, curframe, currentbp, and _user_requested_quit attributes in `Pdb.__init__``.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initialize lineno, stack, curindex, curframe,
currentbp, and _user_requested_quit attributes in
Pdb.__init__instead of at first use. This ensures these attributes are always defined and allowsremoval of defensive getattr/hasattr checks
throughout the codebase.
In particular for a custom PDB subclass in
IPython, the need to use a getattr has performance implications, and while we could set it our
__init__it was easy to send a more global patch to CPython.Should fix gh-140790