-
-
Notifications
You must be signed in to change notification settings - Fork 33.6k
gh-141004: Document PyDict_GET_SIZE
#141078
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-141004: Document PyDict_GET_SIZE
#141078
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Tangent: I must say it is a curious duplication (albeit demoting checks to an assert(PyDict_Check(op));), but I did not look much into it, there may be some good reasoning. Although it seems like something that should be deprecated.
|
We have similar variations for other APIs, such as Thanks for the review! |
|
Thanks @ZeroIntensity for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14. |
(cherry picked from commit f0ab07f) Co-authored-by: Peter Bierma <[email protected]>
|
GH-141082 is a backport of this pull request to the 3.14 branch. |
(cherry picked from commit f0ab07f) Co-authored-by: Peter Bierma <[email protected]>
|
GH-141083 is a backport of this pull request to the 3.13 branch. |
gh-141004: Document `PyDict_GET_SIZE` (GH-141078) (cherry picked from commit f0ab07f) Co-authored-by: Peter Bierma <[email protected]>
gh-141004: Document `PyDict_GET_SIZE` (GH-141078) (cherry picked from commit f0ab07f) Co-authored-by: Peter Bierma <[email protected]>
📚 Documentation preview 📚: https://cpython-previews--141078.org.readthedocs.build/