gh-141004: document Py_INFINITY and Py_NAN macros #141145

skirpichev · 2025-11-06T14:17:31Z

Issue: Document the entire C API #141004

📚 Documentation preview 📚: https://cpython-previews--141145.org.readthedocs.build/

Doc/c-api/float.rst

Co-authored-by: Stan Ulbrych <[email protected]>

Doc/c-api/float.rst

skirpichev · 2025-11-10T23:24:04Z

Deprecation warning was removed, also documented Py_NAN.

ZeroIntensity

Thanks for humoring me :)

miss-islington-app · 2025-11-11T10:14:03Z

Thanks @skirpichev for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖

miss-islington-app · 2025-11-11T10:14:06Z

Sorry, @skirpichev and @vstinner, I could not cleanly backport this to 3.14 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker d69447445cbacf7537bf59c5c683a3b17060312d 3.14

miss-islington-app · 2025-11-11T10:14:11Z

Sorry, @skirpichev and @vstinner, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker d69447445cbacf7537bf59c5c683a3b17060312d 3.13

vstinner · 2025-11-11T10:14:41Z

Merged, thanks.

Sadly, automated backports failed :-( Can you try to backport the change manually to 3.14?

skirpichev · 2025-11-11T10:28:26Z

That's because #141035 wasn't backported. I think we should.

vstinner · 2025-11-11T10:39:30Z

I would prefer to not backport a deprecation like Py_MATH_El.

bedevere-app · 2025-11-11T11:20:39Z

GH-141399 is a backport of this pull request to the 3.14 branch.

…nGH-141145) (cherry picked from commit d694474) Co-authored-by: Sergey B Kirpichev <[email protected]> Co-authored-by: Stan Ulbrych <[email protected]>

bedevere-app · 2025-11-11T11:22:43Z

GH-141400 is a backport of this pull request to the 3.13 branch.

bedevere-bot · 2025-11-11T12:48:02Z

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot AMD64 Fedora Stable Refleaks 3.x (tier-1) has failed when building commit d694474.

What do you need to do:

Don't panic.
Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/320/builds/3289) and take a look at the build logs.
Check if the failure is related to this commit (d694474) or if it is a false positive.
If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/320/builds/3289

Failed tests:

test.test_multiprocessing_fork.test_processes

Failed subtests:

test_interrupt - test.test_multiprocessing_fork.test_processes.WithProcessesTestProcess.test_interrupt

Summary of the results of the build (if available):

==

Click to see traceback logs

Traceback (most recent call last):
  File "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-x86_64.refleak/build/Lib/multiprocessing/process.py", line 320, in _bootstrap
    self.run()
    ~~~~~~~~^^
  File "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-x86_64.refleak/build/Lib/multiprocessing/process.py", line 108, in run
    self._target(*self._args, **self._kwargs)
    ~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-x86_64.refleak/build/Lib/test/_test_multiprocessing.py", line 524, in _sleep_some_event
    time.sleep(100)
    ~~~~~~~~~~^^^^^
KeyboardInterrupt
k


Traceback (most recent call last):
  File "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-x86_64.refleak/build/Lib/contextlib.py", line 85, in inner
    return func(*args, **kwds)
  File "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-x86_64.refleak/build/Lib/test/_test_multiprocessing.py", line 596, in test_interrupt
    exitcode = self._kill_process(multiprocessing.Process.interrupt)
  File "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-x86_64.refleak/build/Lib/contextlib.py", line 85, in inner
    return func(*args, **kwds)
  File "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-x86_64.refleak/build/Lib/test/_test_multiprocessing.py", line 577, in _kill_process
    self.assertEqual(join(), None)
                     ~~~~^^
  File "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-x86_64.refleak/build/Lib/test/_test_multiprocessing.py", line 250, in __call__
    return self.func(*args, **kwds)
           ~~~~~~~~~^^^^^^^^^^^^^^^
  File "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-x86_64.refleak/build/Lib/multiprocessing/process.py", line 156, in join
    res = self._popen.wait(timeout)
  File "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-x86_64.refleak/build/Lib/multiprocessing/popen_fork.py", line 44, in wait
    return self.poll(os.WNOHANG if timeout == 0.0 else 0)
           ~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-x86_64.refleak/build/Lib/multiprocessing/popen_fork.py", line 28, in poll
    pid, sts = os.waitpid(self.pid, flag)
               ~~~~~~~~~~^^^^^^^^^^^^^^^^
  File "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-x86_64.refleak/build/Lib/test/_test_multiprocessing.py", line 573, in handler
    raise RuntimeError('join took too long: %s' % p)
RuntimeError: join took too long: <Process name='Process-6' pid=2441711 parent=2441704 started daemon>


Traceback (most recent call last):
  File "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-x86_64.refleak/build/Lib/contextlib.py", line 85, in inner
    return func(*args, **kwds)
  File "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-x86_64.refleak/build/Lib/test/_test_multiprocessing.py", line 596, in test_interrupt
    exitcode = self._kill_process(multiprocessing.Process.interrupt)
  File "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-x86_64.refleak/build/Lib/contextlib.py", line 85, in inner
    return func(*args, **kwds)
  File "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-x86_64.refleak/build/Lib/test/_test_multiprocessing.py", line 577, in _kill_process
    self.assertEqual(join(), None)
                     ~~~~^^
  File "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-x86_64.refleak/build/Lib/test/_test_multiprocessing.py", line 250, in __call__
    return self.func(*args, **kwds)
           ~~~~~~~~~^^^^^^^^^^^^^^^
  File "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-x86_64.refleak/build/Lib/multiprocessing/process.py", line 156, in join
    res = self._popen.wait(timeout)
  File "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-x86_64.refleak/build/Lib/multiprocessing/popen_fork.py", line 44, in wait
    return self.poll(os.WNOHANG if timeout == 0.0 else 0)
           ~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-x86_64.refleak/build/Lib/multiprocessing/popen_fork.py", line 28, in poll
    pid, sts = os.waitpid(self.pid, flag)
               ~~~~~~~~~~^^^^^^^^^^^^^^^^
  File "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-x86_64.refleak/build/Lib/test/_test_multiprocessing.py", line 573, in handler
    raise RuntimeError('join took too long: %s' % p)
RuntimeError: join took too long: <Process name='Process-150' pid=2428123 parent=2426671 started daemon>

…141400) (cherry picked from commit d694474) Co-authored-by: Stan Ulbrych <[email protected]>

…141399) (cherry picked from commit d694474) Co-authored-by: Stan Ulbrych <[email protected]>

Co-authored-by: Stan Ulbrych <[email protected]>

pythongh-141004: document Py_INFINITY macro

56740f1

skirpichev added needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels Nov 6, 2025

bedevere-app bot added awaiting review docs Documentation in the Doc dir skip news labels Nov 6, 2025

github-project-automation bot added this to Docs PRs Nov 6, 2025

github-project-automation bot moved this to Todo in Docs PRs Nov 6, 2025

bedevere-app bot mentioned this pull request Nov 6, 2025

Document the entire C API #141004

Open

skirpichev mentioned this pull request Nov 6, 2025

gh-141004: soft-deprecate Py_INFINITY macro #141033

Merged

ZeroIntensity reviewed Nov 6, 2025

View reviewed changes

Doc/c-api/float.rst Outdated Show resolved Hide resolved

StanFromIreland reviewed Nov 6, 2025

View reviewed changes

Doc/c-api/float.rst Outdated Show resolved Hide resolved

Update Doc/c-api/float.rst

33bbedc

Co-authored-by: Stan Ulbrych <[email protected]>

skirpichev commented Nov 7, 2025

View reviewed changes

Doc/c-api/float.rst Outdated Show resolved Hide resolved

skirpichev added 3 commits November 11, 2025 02:09

Merge branch 'main' into document-Py_INFINITY/141004

019117e

Update Doc/c-api/float.rst

4a7d572

+ document Py_NAN

81d373d

skirpichev changed the title ~~gh-141004: document Py_INFINITY macro~~ gh-141004: document Py_INFINITY and Py_NAN macros Nov 10, 2025

skirpichev requested review from ZeroIntensity and vstinner November 10, 2025 23:23

+1

eeb7fb3

ZeroIntensity approved these changes Nov 11, 2025

View reviewed changes

bedevere-app bot added awaiting merge and removed awaiting review labels Nov 11, 2025

vstinner merged commit d694474 into python:main Nov 11, 2025
32 checks passed

bedevere-app bot removed the awaiting merge label Nov 11, 2025

github-project-automation bot moved this from Todo to Done in Docs PRs Nov 11, 2025

miss-islington-app bot assigned vstinner Nov 11, 2025

skirpichev deleted the document-Py_INFINITY/141004 branch November 11, 2025 10:19

This comment has been minimized.

Sign in to view

bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label Nov 11, 2025

bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Nov 11, 2025

vstinner pushed a commit that referenced this pull request Nov 11, 2025

[3.13] gh-141004: document Py_INFINITY and Py_NAN macros (GH-141145) (#…

05e7b0d

…141400) (cherry picked from commit d694474) Co-authored-by: Stan Ulbrych <[email protected]>

vstinner pushed a commit that referenced this pull request Nov 11, 2025

[3.14] gh-141004: document Py_INFINITY and Py_NAN macros (GH-141145) (#…

8b94940

…141399) (cherry picked from commit d694474) Co-authored-by: Stan Ulbrych <[email protected]>

StanFromIreland added a commit to StanFromIreland/cpython that referenced this pull request Dec 6, 2025

pythongh-141004: document Py_INFINITY and Py_NAN macros (python#141145)

af9e8c7

Co-authored-by: Stan Ulbrych <[email protected]>

Uh oh!

gh-141004: document Py_INFINITY and Py_NAN macros #141145

gh-141004: document Py_INFINITY and Py_NAN macros #141145

Uh oh!

Conversation

skirpichev commented Nov 6, 2025 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

skirpichev commented Nov 10, 2025

Uh oh!

ZeroIntensity left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

miss-islington-app bot commented Nov 11, 2025

Uh oh!

miss-islington-app bot commented Nov 11, 2025

Uh oh!

miss-islington-app bot commented Nov 11, 2025

Uh oh!

vstinner commented Nov 11, 2025

Uh oh!

skirpichev commented Nov 11, 2025

Uh oh!

vstinner commented Nov 11, 2025

Uh oh!

This comment has been minimized.

bedevere-app bot commented Nov 11, 2025

Uh oh!

bedevere-app bot commented Nov 11, 2025

Uh oh!

bedevere-bot commented Nov 11, 2025

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

skirpichev commented Nov 6, 2025 •

edited by github-actions bot

Loading