gh-141004: correctly document Py_HASH_* and PyHASH_* as hash_info attributes
#141233
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
picnixz
added
skip news
needs backport to 3.13
picnixz
force-pushed
the
fix/capi/hash-bits-141004
branch
from
595bd7a to
adb27bd
Compare
picnixz
force-pushed
the
fix/capi/hash-bits-141004
branch
from
adb27bd to
a058142
Compare
|
Thanks @picnixz for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Nov 8, 2025
…sh_info` attributes (pythonGH-141233) (cherry picked from commit 87942d9) Co-authored-by: Bénédikt Tran <[email protected]>
|
GH-141234 is a backport of this pull request to the 3.14 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Nov 8, 2025
…sh_info` attributes (pythonGH-141233) (cherry picked from commit 87942d9) Co-authored-by: Bénédikt Tran <[email protected]>
|
GH-141235 is a backport of this pull request to the 3.13 branch. |
picnixz
added a commit
that referenced
this pull request
Nov 8, 2025
picnixz
added a commit
that referenced
this pull request
Nov 8, 2025
StanFromIreland
pushed a commit
to StanFromIreland/cpython
that referenced
this pull request
Dec 6, 2025
…sh_info` attributes (python#141233)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My very bad, I incorrectly documented PyHASH_BITS as hash_info.hash_bits, but the former is for numerical schemes while the latter is for strings schemes. I also added a newline before the "This corresponds to ..." and added the link to
cutoffforPy_HASH_CUTOFF.📚 Documentation preview 📚: https://cpython-previews--141233.org.readthedocs.build/