gh-141004: Document PyFunction_SetKwDefaults
#141294
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZeroIntensity
added
needs backport to 3.13
bedevere-app
bot
added
awaiting core review
docs
I'm sleepy.
Comment on lines
+107
to
+108
| Set the keyword-only argument default values of the function object *op*. | ||
| *defaults* must be a dictionary of keyword-only arguments or ``Py_None``. |
Member
There was a problem hiding this comment.
Suggested change
| Set the keyword-only argument default values of the function object *op*. | |
| *defaults* must be a dictionary of keyword-only arguments or ``Py_None``. | |
| Set the keyword-only parameter default values of the function object *op*. | |
| *defaults* must be a dictionary of keyword-only parameters or ``Py_None``. |
Member
Author
There was a problem hiding this comment.
We say "argument" everywhere else in this file, so I'd rather not deviate from it here. I don't think that the distinction is particularly helpful for readers here.
Member
There was a problem hiding this comment.
I'm not a fan of such a precedent, but unfortunately it is. Fixing this is tracked in #133438.
|
Thanks @ZeroIntensity for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Nov 9, 2025
(cherry picked from commit 18529b5) Co-authored-by: Peter Bierma <[email protected]>
|
GH-141304 is a backport of this pull request to the 3.14 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Nov 9, 2025
(cherry picked from commit 18529b5) Co-authored-by: Peter Bierma <[email protected]>
|
GH-141305 is a backport of this pull request to the 3.13 branch. |
ZeroIntensity
added a commit
that referenced
this pull request
Nov 9, 2025
…-141305) gh-141004: Document `PyFunction_SetKwDefaults` (GH-141294) (cherry picked from commit 18529b5) Co-authored-by: Peter Bierma <[email protected]>
ZeroIntensity
added a commit
that referenced
this pull request
Nov 9, 2025
…-141304) gh-141004: Document `PyFunction_SetKwDefaults` (GH-141294) (cherry picked from commit 18529b5) Co-authored-by: Peter Bierma <[email protected]>
StanFromIreland
pushed a commit
to StanFromIreland/cpython
that referenced
this pull request
Dec 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📚 Documentation preview 📚: https://cpython-previews--141294.org.readthedocs.build/en/141294/c-api/function.html#c.PyFunction_SetKwDefaults