gh-141004: Document descriptor and dict proxy type objects #141803
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bedevere-app
bot
added
awaiting review
docs
Contributor
Author
|
Hi @ZeroIntensity, thanks for the review and apologies for the delay. I've addressed all the feedback:
All checks are passing. Please let me know if anything else needs adjustment. |
Member
ZeroIntensity
left a comment
ZeroIntensity
left a comment
There was a problem hiding this comment.
Looks pretty good, a few final comments.
Doc/c-api/descriptor.rst
Outdated
Comment on lines
28
to
29
| C struct as attributes on a type, and correspond to :class:`types.MemberDescriptorType` | ||
| objects in the Python layer. |
Member
There was a problem hiding this comment.
We try to keep lines below 80 characters, but this line exceeds that limit. Same goes for a few lines below.
Co-authored-by: Peter Bierma <[email protected]>
Co-authored-by: Victor Stinner <[email protected]>
ZeroIntensity
added
needs backport to 3.13
|
Thanks @Yashp002 for the PR, and @ZeroIntensity for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Dec 1, 2025
…honGH-141803) (cherry picked from commit 52f9b5f) Co-authored-by: Yashraj <[email protected]> Co-authored-by: Peter Bierma <[email protected]> Co-authored-by: Victor Stinner <[email protected]>
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Dec 1, 2025
…honGH-141803) (cherry picked from commit 52f9b5f) Co-authored-by: Yashraj <[email protected]> Co-authored-by: Peter Bierma <[email protected]> Co-authored-by: Victor Stinner <[email protected]>
|
GH-142147 is a backport of this pull request to the 3.14 branch. |
|
GH-142148 is a backport of this pull request to the 3.13 branch. |
ZeroIntensity
added a commit
that referenced
this pull request
Dec 1, 2025
…-141803) (GH142147) gh-141004: Document descriptor and dict proxy type objects (GH-141803) (cherry picked from commit 52f9b5f) Co-authored-by: Yashraj <[email protected]> Co-authored-by: Peter Bierma <[email protected]> Co-authored-by: Victor Stinner <[email protected]>
ZeroIntensity
added a commit
that referenced
this pull request
Dec 1, 2025
…-141803) (GH-142148) gh-141004: Document descriptor and dict proxy type objects (GH-141803) (cherry picked from commit 52f9b5f) Co-authored-by: Yashraj <[email protected]> Co-authored-by: Peter Bierma <[email protected]> Co-authored-by: Victor Stinner <[email protected]>
Contributor
Author
|
Thanks @ZeroIntensity for the guidance :) |
StanFromIreland
pushed a commit
to StanFromIreland/cpython
that referenced
this pull request
Dec 6, 2025
…honGH-141803) Co-authored-by: Peter Bierma <[email protected]> Co-authored-by: Victor Stinner <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds C API documentation for six previously undocumented type objects:
In
Doc/c-api/descriptor.rst:PyClassMethodDescr_Type- type for class method descriptorsPyGetSetDescr_Type- type for get/set descriptorsPyMemberDescr_Type- type for member descriptorsPyMethodDescr_Type- type for method descriptorsPyWrapperDescr_Type- type for wrapper descriptorsIn
Doc/c-api/dict.rst:PyDictProxy_Type- type for mapping proxy objectsEach entry follows the existing documentation style and includes a brief description of the type's purpose and its relationship to the Python layer.
Contributes to #141004.
📚 Documentation preview 📚: https://cpython-previews--141803.org.readthedocs.build/