GH-141808: Do not generate the jit stencils twice in case of PGO builds on Windows. #142043
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gpshead
approved these changes
Nov 29, 2025
gpshead
added
the
🔨 test-with-buildbots
|
🤖 New build scheduled with the buildbot fleet by @gpshead for commit fb17f11 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F142043%2Fmerge If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again. |
bedevere-bot
removed
the
🔨 test-with-buildbots
|
Thanks @chris-eibl for the PR, and @gpshead for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Nov 29, 2025
…O builds on Windows. (pythonGH-142043) * do not build the jit stencils twice in case of PGO builds on Windows * blurb it (cherry picked from commit f2ca158) Co-authored-by: Chris Eibl <[email protected]>
|
GH-142100 is a backport of this pull request to the 3.14 branch. |
gpshead
pushed a commit
that referenced
this pull request
Nov 29, 2025
…GO builds on Windows. (GH-142043) (#142100) GH-141808: Do not generate the jit stencils twice in case of PGO builds on Windows. (GH-142043) * do not build the jit stencils twice in case of PGO builds on Windows * blurb it (cherry picked from commit f2ca158) Co-authored-by: Chris Eibl <[email protected]>
StanFromIreland
pushed a commit
to StanFromIreland/cpython
that referenced
this pull request
Dec 6, 2025
…O builds on Windows. (pythonGH-142043) * do not build the jit stencils twice in case of PGO builds on Windows * blurb it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just re-use them in the PGUpdate phase: by using the same folder as in the PGInstrument phase, the hash will just match and the stencils are not built again. This saves time, especially on old PCs like mine, where the stencils generation takes about a minute.