GH-139862: Fix direct instantiation of HelpFormatter
#142384
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
@hamdanal Mind also taking a look at this and making sure everything is fixed on your end? |
hamdanal
approved these changes
Dec 7, 2025
Contributor
hamdanal
left a comment
hamdanal
left a comment
There was a problem hiding this comment.
This fixes the problem. Thank you.
hugovk
approved these changes
Dec 7, 2025
Member
hugovk
left a comment
hugovk
left a comment
There was a problem hiding this comment.
Worth adding a regression test?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #142274 (comment), the issue here is that
format_help()eventually accessesself._themebut_themewas never set since_set_color()is no longer called in__init__. I think we can initialize_themeto a safe default (no color) so that direct instantiation works but the parser can still override it afterward.argparseformatter handling ofcolor#139862