Skip to content

bpo-40334: Fix builds outside the source directory and regenerate autoconf files #19667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
pablogsal merged 1 commit into from
Apr 23, 2020
Merged

bpo-40334: Fix builds outside the source directory and regenerate autoconf files #19667

pablogsal merged 1 commit into from
Apr 23, 2020

Conversation

@pablogsal
Copy link
Member

@pablogsal pablogsal commented Apr 22, 2020 •
edited by bedevere-bot
Loading

@pablogsal pablogsal requested a review from ned-deily April 22, 2020 23:42
@pablogsal
Copy link
Member Author

pablogsal commented Apr 22, 2020

The extra diff is the result of running autoreconf

@pablogsal pablogsal requested a review from vstinner April 22, 2020 23:46
ned-deily
ned-deily approved these changes Apr 22, 2020
View reviewed changes
Copy link
Member

@ned-deily ned-deily left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@pablogsal pablogsal merged commit a25f3c4 into python:master Apr 23, 2020
@pablogsal pablogsal deleted the fix_outsidedir branch April 23, 2020 00:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ned-deily ned-deily ned-deily approved these changes

@vstinner vstinner Awaiting requested review from vstinner

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@pablogsal @ned-deily @the-knights-who-say-ni @bedevere-bot