bpo-40334: Explicitly cast to int in pegen.c to fix a compiler warning #19779
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pablogsal
force-pushed
the
bpo-40334-warnings
branch
from
b465e57 to
edb3f4b
Compare
vstinner
approved these changes
Apr 29, 2020
Member
vstinner
left a comment
vstinner
left a comment
There was a problem hiding this comment.
LGTM.
The other option is to change Token structure to use Py_ssize_t. But it would require to modify Python-ast.c to accept line number and column as Py_ssize_t as well. And then fix further issues of code using int, etc. I'm not sure that we have to support lines longer than 2 GB.
The previous person who made the warning quiet didn't try to raise an error for a line longer than 2 GB:
commit cad876d54273e6f3f9cb3ff575da1c45ef5410c6
Author: Victor Stinner <[email protected]>
Date: Mon Nov 18 01:09:51 2013 +0100
Fix a compiler warning on Windows 64-bit in parsetok.c
Python parser doesn't support lines longer than INT_MAX bytes yet
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue40334