-
-
Notifications
You must be signed in to change notification settings - Fork 33.6k
bpo-40334: Improve column offsets for thrown syntax errors by Pegen #19782
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
lysnikolaou
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @isidentical for spending time on this! It's a really nice improvement.
|
@isidentical there's a merge conflict -- you need to merge master and run |
|
@gvanrossum resolved |
Best way of fixing a bug! 🎉 |
|
The travis target is stucked, closing and reopening to re-trigger the CI |
|
Hummm, there is a bunch of warnings now after the last rebasing: @isidentical could you take a look? Seems that we are passing the error message incorrectly with this PR |
Yup, this PR changes signature of _PyPegen_raise_error. I missed that usage when I rebased. Now, it should be fixed. |
I've been trying to figure out a good way to handle
ast.cerrors, but no luck so far. I've splitted them to their own test and fixed remaining offset errors to ensure full compatibility with the old parser.https://bugs.python.org/issue40334